Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to webpack-dev-middleware 7.0.0 #5027

Closed
reaktivo opened this issue Jan 9, 2024 · 2 comments
Closed

Update to webpack-dev-middleware 7.0.0 #5027

reaktivo opened this issue Jan 9, 2024 · 2 comments

Comments

@reaktivo
Copy link

reaktivo commented Jan 9, 2024

Bug report

Currently webpack-dev-server throws errors when used with Node >20 due to a old memfs being referenced as a transitive dependency.

webpack-dev-middleware has already been updated as of this PR.

Now the last remaining piece is for webpack-dev-server to point to latest webpack-dev-middleware.

Actual Behavior

Throws the following error:

node:events:492
      throw er; // Unhandled 'error' event
      ^

TypeError: Cannot set property closed of #<Readable> which has only a getter
    at FsReadStream.close (/Users/x/dev/client/node_modules/memfs/lib/volume.js:2047:17)
    at FsReadStream._destroy (/Users/x/dev/client/node_modules/memfs/lib/volume.js:2032:10)
    at _destroy (node:internal/streams/destroy:109:10)

Expected Behavior

Should not throw memfs errors

How Do We Reproduce?

Please paste the results of npx webpack-cli info here, and mention other relevant information

@alexander-akait
Copy link
Member

We will do it in the next major release to avoid breaking changes, it will be soon

@alexander-akait
Copy link
Member

Done in the master/main, release will be soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants