-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Can't use disableHostCheck
option - v2.4.3
#883
Comments
Could you explain why you want to disable this security feature? |
released in v2.4.4 |
@sokra, can it be that this is connected with #533 (comment)? |
@sokra Sometimes I need to test out features directly on my phone, and to do that I need to use the IP address of my computer that's running webpack-dev-server as the host to be able to connect to it. I'm not totally sure that this security feature is necessary for me because when I use webpack-dev-server I'm either on a network with people I trust (home or work), or if I'm on a public network I keep my ports closed. |
This security feature protects against a DNS rebinding attack I reported privately to the webpack team, which may still affect you depending on your exact setup. |
Oh I see. In that case I'll leave the host check enabled and only disable it when I absolutely need to (which is rarely anyway). |
I've filed a retrospective GitHub issue with the original private disclosure email wording, which should hopefully make things a bit clearer: #887 - happy to answer any additional questions. I've also made a suggestion about improving the UX for the "use a dynamic IP to access from a mobile device" case in #882 (comment) |
@bdwain have you tried setting |
I am still unable to use disableHostCheck flag -_- ng serve --host 0.0.0.0 --disableHostCheck=true help please |
@tanzeelrana That sounds like a feature request to open with Angular CLI project. Their CLI has to support disableHostCheck option and pass it to Webpack. |
When trying to use the
disableHostCheck
option withv2.4.3
, I get:I'm guessing
disableHostCheck
just needs to be added tooptionsSchema.json
.The text was updated successfully, but these errors were encountered: