Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation - Arabic and Turkish #1593

Closed
2 tasks
AhmedAbdulrahman opened this issue Sep 13, 2017 · 10 comments
Closed
2 tasks

Translation - Arabic and Turkish #1593

AhmedAbdulrahman opened this issue Sep 13, 2017 · 10 comments

Comments

@AhmedAbdulrahman
Copy link

AhmedAbdulrahman commented Sep 13, 2017

Hi, I would like to contribute to webpack documentation for translation into the following languages?

  • Arabic
  • Turkish

What I have done so far:

  1. Fork the repo
  2. Clone it
  3. Run the following commands:
  • npm install
  • npm run build
  • npm start
  • npm run fetch
  1. Created new branch for translation in my fork.

Any other things?
Thanks!

Screen Capture
screenshot-localhost-3000-2017-09-13-15-39-33

@skipjack
Copy link
Collaborator

Awesome, glad you're interested in tackling this! So we do have a potential long-term plan for making translation easier in #295. However this is likely still a ways off. Here's how we handle it now:

  • Fork the repository (as you've already done)
  • Translate the content
  • Rebase on the existing translation branch we've created in the main repository

@lcxfs1991 @Lutece could you elaborate on the steps above and correct me if I got anything wrong? (I wouldn't mind knowing a bit more about the current workflow myself as I may be able to add more content to Translation section in our README). @AhmedAbdulrahman these are two of our maintainers for other translated forks so they should be able to help you more than I can.

Once we hear from them, I'll close this out. However, @AhmedAbdulrahman you should ping me once you have something ready to go so we can add a link to these new translations in our banner.

@Lutece
Copy link
Contributor

Lutece commented Sep 13, 2017

@AhmedAbdulrahman

Hi :) I'm Lutece who is translating the 'Webpack Docs' into Korean
I succeeded in connecting the domain temporarily by referring to the blog post by @lcxfs1991.
This is the URL of the post.

https://medium.com/@lcxfs1991/deploy-using-travis-ci-and-github-webhook-eba67b3ab6ac

@lcxfs1991 Thanks for writing this post :)

@skipjack
Copy link
Collaborator

cc @dear-lizhihua (I know you work on some translation stuff as well)

@Lutece @dear-lizhihua @lcxfs1991 are any of you in our slack channels yet? I think it might make sense for us to create an #i18n channel so we have a place to discuss things offline when necessary. @AhmedAbdulrahman I think we'd be happy to add you there as well. @TheLarkInn what do you think?

@AhmedAbdulrahman also you should be able to take npm run fetch out of your command list above. That command is run automatically by npm start and npm build already.

@Lutece
Copy link
Contributor

Lutece commented Sep 14, 2017

@skipjack Hello :)
I'm not joined in Slack channel of webpack yet, How can i do join in there?

@skipjack
Copy link
Collaborator

@Lutece we will add you, I just have to talk to someone with permissions first.

@AhmedAbdulrahman I'm going to close as I'm not sure what else we can add here. Feel free to keep discussing though and I'll work on getting you all invited to slack. Were there any other questions you had?

@dear-lizhihua
Copy link
Collaborator

@AhmedAbdulrahman @skipjack
we use translation branch to update third-party loaders and plugins.
So you should merge translation branch to your xxx branch, you won't need npm run fetch to get loaders/*.md and plugins/*.md, because we do it at translation branch.

image
image

@dear-lizhihua
Copy link
Collaborator

like this:

master                                  translation
(not loaders/*.md & not plugins/*.md)   (loaders/*.md & plugins/*.md)
      |                                        |
          \                                /
             \                         /
                 \                 /
                       |
                       |
               cn (or your branch)

@dear-lizhihua
Copy link
Collaborator

dear-lizhihua commented Sep 15, 2017

image

we split src/scripts/fetch.sh, like copy, fetch and fetch-logo:

  • copy: copy ./src/content/loaders/ to ./generated/loaders & copy ./src/content/plugins/ to ./generated/plugins
  • fetch: we npm run fetch at translation branch, to update third-party loaders and plugins.
  • fetch-logo: node ./src/scripts/fetch_supporters.js & node ./src/scripts/fetch_starter_kits.js

@skipjack
Copy link
Collaborator

@dear-lizhihua can you send me your email address so we can invite you to our slack channel? Feel free to pm me on gitter if you don't want to share here.

@dear-lizhihua
Copy link
Collaborator

OK, my email is 275091674@qq.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants