Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Extremely slow import of wacz file (in Brave extension) #212

Closed
ZheniaZuser opened this issue May 4, 2024 · 3 comments
Closed

[Bug]: Extremely slow import of wacz file (in Brave extension) #212

ZheniaZuser opened this issue May 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ZheniaZuser
Copy link

ZheniaZuser commented May 4, 2024

ArchiveWeb.page Version

v0.11.3

What did you expect to happen? What happened instead?

Trying to import .wacz file that was created there a few days ago.
Note: File chooser is invisible in recording
https://youtu.be/ZyHv1rIsTTw

Step-by-step reproduction instructions

Try to import this file: https://drive.google.com/file/d/1RfUxe1SGSVkkFGQm1uX-_TlwTRi7epp8/view?usp=drive_link

Additional details

This file was created there a few days ago by me

@ZheniaZuser ZheniaZuser added the bug Something isn't working label May 4, 2024
@ikreymer
Copy link
Member

ikreymer commented Jun 4, 2024

How slow was it importing? I just tried with latest build of 0.12.0 and it imported in <1 min - it looks like the WACZ has a lot of small files in it. The import speed has less to do with total size, but with number of archived URLs in the archive.

@ikreymer
Copy link
Member

ikreymer commented Jun 4, 2024

Ah, just tested in Brave, and do indeed see that it is slow as well - seems to only happen in Brave, tested Chrome, Chrome Beta and Canary (Chrome 125, 126, 127) and seems to be uploading fine there...

@ikreymer ikreymer changed the title [Bug]: Extremely slow import of wacz file [Bug]: Extremely slow import of wacz file (in Brave extension) Jun 4, 2024
@ikreymer
Copy link
Member

ikreymer commented Jun 4, 2024

I found the source of the issue, it is because Brave disable the native file system api by default, which the extension assumed was available in Chromium-based browsers: brave/brave-browser#18979
(Without it, I think it ends up loading the whole object into memory, instead of streaming, which is something to be fixed separately).

But the good news, is that you can enable it if you go to brave://flags and search for File System Access API and then reload Brave. Uploading should now work just as fast as in Chrome.

Will close this for now as that resolves the immediate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done!
Development

No branches or pull requests

2 participants