Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming for yuv helper #113

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Fix naming for yuv helper #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d842d1
add PrivacyInfo.xcprivacy to darwin frameworks.
cloudwebrtc Apr 25, 2024
2db1f72
Fix some function naming of yuv helper.
cloudwebrtc Apr 25, 2024
c216fa5
revert changes.
cloudwebrtc Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/objc/helpers/RTCYUVHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ RTC_OBJC_EXPORT
dstV:(uint8_t*)dstV
dstStrideV:(int)dstStrideV
width:(int)width
width:(int)height
height:(int)height
mode:(RTCVideoRotation)mode;

+ (int)I420ToNV12:(const uint8_t*)srcY
Expand All @@ -45,7 +45,7 @@ RTC_OBJC_EXPORT
dstUV:(uint8_t*)dstUV
dstStrideUV:(int)dstStrideUV
width:(int)width
width:(int)height;
height:(int)height;

+ (int)I420ToNV21:(const uint8_t*)srcY
srcStrideY:(int)srcStrideY
Expand All @@ -58,7 +58,7 @@ RTC_OBJC_EXPORT
dstUV:(uint8_t*)dstUV
dstStrideUV:(int)dstStrideUV
width:(int)width
width:(int)height;
height:(int)height;

+ (int)I420ToARGB:(const uint8_t*)srcY
srcStrideY:(int)srcStrideY
Expand Down
6 changes: 3 additions & 3 deletions sdk/objc/helpers/RTCYUVHelper.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ + (void)I420Rotate:(const uint8_t*)srcY
dstV:(uint8_t*)dstV
dstStrideV:(int)dstStrideV
width:(int)width
width:(int)height
height:(int)height
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow... nice catch!

mode:(RTCVideoRotation)mode {
libyuv::I420Rotate(srcY,
srcStrideY,
Expand Down Expand Up @@ -57,7 +57,7 @@ + (int)I420ToNV12:(const uint8_t*)srcY
dstUV:(uint8_t*)dstUV
dstStrideUV:(int)dstStrideUV
width:(int)width
width:(int)height {
height:(int)height {
return libyuv::I420ToNV12(srcY,
srcStrideY,
srcU,
Expand All @@ -83,7 +83,7 @@ + (int)I420ToNV21:(const uint8_t*)srcY
dstUV:(uint8_t*)dstUV
dstStrideUV:(int)dstStrideUV
width:(int)width
width:(int)height {
height:(int)height {
return libyuv::I420ToNV21(srcY,
srcStrideY,
srcU,
Expand Down