Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rtcpeerconnection-shim an optional dependency #1068

Closed
fippo opened this issue Feb 13, 2021 · 2 comments
Closed

make rtcpeerconnection-shim an optional dependency #1068

fippo opened this issue Feb 13, 2021 · 2 comments

Comments

@fippo
Copy link
Member

fippo commented Feb 13, 2021

with legacy edge going away soon it might make sense to make the wicked shim an optional dependency
See https://docs.npmjs.com/cli/v7/configuring-npm/package-json#optionaldependencies for the mechanics.

Needs a major version
@fippo
Copy link
Member Author

fippo commented Feb 13, 2021

hm, this doesn't seem to do what I want (@legastero can you advise?).
Maybe just remove legacy edge support at the next major version...

@fippo
Copy link
Member Author

fippo commented May 6, 2021

#1076 fixes this, 🎉 @saghul

@fippo fippo closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fippo