Memory Leak

[lawlmart]

I've trying to track down a memory leak that seems to be related to ws. My socket server has ~ 300 connections per second and peaks out at around 15000 concurrents before running out of memory (8 gb). Memory usage seems to rise linearly (proportional to new connections, not concurrent connections). Here's what I believe to be the relevant part of the heap dump:

Thanks in advance for your assistance.

[lpinca]

Can you try to disable the permessage-deflate extension?
Possible duplicate of #804.

[lawlmart]

Yes, same result just without the deflate calls in the stack.

I also checked gc and it appeared to be running fine, but I don't have much experience debugging this sort of thing.

[lpinca]

I'm kinda new to ws codebase so I'm not sure where to look.
Did you also try to disable client tracking?
Is it possible to reproduce the issue somehow?
Thanks.

[schwiet]

I too wonder if it has to do with client tracking, which does not seem to work for me, at least when a client has disconnected. If I print wss.clients.length each 'connection' event and then again each time a client hits onclose, I see something like:

client connected:  1 clients
client disconnected. 1 clients

client connected:  2 clients
client disconnected. 2 clients

client connected:  3 clients
client disconnected. 3 clients

client connected:  4 clients
client disconnected. 4 clients

client connected:  5 clients
client disconnected. 5 clients

client connected:  6 clients
client disconnected. 6 clients

Looks like clients are not removed upon disconnection, which seems like it would be the expected behavior, right?

[schwiet]

#967 possibly related.

[lpinca]

@lawlmart were you using ws.onclose = function () {}; on the server?

[lawlmart]

No, I'm not.

[lpinca]

Can you try with ws@beta and see if the issue persists? Also disable permessage-deflate if you can.

Thanks.

[lpinca]

Closing as I can't reproduce the issue. Please post back if you have more info.
Thanks.