peers: handle maxAge option #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2018
Closed
mafintosh
reviewed
Jan 10, 2018
README.md
Outdated
| @@ -82,6 +82,8 @@ If `opts` is specified, then the default options (shown below) will be overridde | |||
| concurrency: 16, // k-rpc option to specify maximum concurrent UDP requests allowed (Number, 16 by default) | |||
| hash: Function, // custom hash function to use (Function, SHA1 by default), | |||
| krpc: krpc() // optional k-rpc instance | |||
| timeBucketOutdated: 900000 // check buckets every 15min | |||
| maxAge: Infinity // optional setting for announced peers to time out | |||
There was a problem hiding this comment.
could you some missing , above? :)
robertkowalski
force-pushed
the
maxAge
branch
from
5623532
to
64c9610
Compare
handle option maxAge to remove stale peers from peercache
robertkowalski
force-pushed
the
maxAge
branch
from
1186ea3
to
a4b580c
Compare
|
It is failing because of standard, I'll fix that. |
|
ugh sorry, my bad
…On Wed, Jan 10, 2018 at 5:53 PM, Mathias Buus ***@***.***> wrote:
It is failing because of standard, I'll fix that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#186 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASMtt4yfkESDfCyrjOi5_88Ob1CyoSKks5tJOrsgaJpZM4RZVqc>
.
|
|
7.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle option maxAge to remove stale peers from peercache