Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started overview #935

Merged
merged 23 commits into from
Jul 10, 2021
Merged

Conversation

shwetalsoni
Copy link
Member

@shwetalsoni shwetalsoni commented Jun 10, 2021

Screenshot from 2021-06-14 11-27-48
Screenshot from 2021-06-10 17-26-47

@shwetalsoni shwetalsoni requested a review from a team as a code owner June 10, 2021 11:57
@shwetalsoni
Copy link
Member Author

This PR is renewed PR for #897.

@shwetalsoni
Copy link
Member Author

Tag #891

@shwetalsoni shwetalsoni added GSoD 2021 tutorials Related to tutorial docs labels Jun 10, 2021
If you are a total beginner to Wechaty, start from this section.

You can run Wechaty on following platforms:
* [Cloud IDE](getting-started/quick-start.mdx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one little suggestion here, it would be nice to use Google Cloud Shell here instead of Cloud IDE as in the other pages of the docs we are referring it by this name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes seems legit

@Rohitesh-Kumar-Jain
Copy link
Contributor

@shwetalsoni thanks for renewing the PR, PR looks good to me, Souvik suggested a valid point, pls do consider that.

Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if you have any question.

Comment on lines 23 to 31
* With just a few lines of code, your WeChat/Whatsapp account will be turned into a chatbot, a.k.a [Conversational User Interface](https://en.wikipedia.org/wiki/Conversational_user_interface) Automation Software.

* With the power of the Wechaty Conversational RPA technology, your chatbot will have conversations on behalf of you, and can do whatever you want to do.

* It works out of the box on **Linux**, **Mac** and **Windows**.

* Supports all [puppets](../puppet-services) like Web, Pad, Windows and Mac.

* It replies with a `dong` message when it recieves a `ding` message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align the sentences structure under the list. For example:

  • Turn a WeChat/Whatsapp account into a chatbot, a.k.a Conversational User Interface Automation Software, with just a few lines of code.
  • Represent the user with the power of Wechaty Conversational RPA technology.
  • Work out of the box on Linux, Mac and Windows.
  • Support all puppets like Web, Pad, Windows and Mac.
  • Reply with a dong message when it recieves a ding message.

(Or you could rewrite the sentences yourself)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes @proudofsimin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shwetalsoni,
Thank you for your prompt reply, but these sentences should all start from a verb and omit the subject. How do you think if we change the second one to "Use the chatbot to communicate or do anything on behalf of you."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Use the chatbot to communicate or do anything on behalf of you.

Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect PR : clean commit history, properly based, relevant screenshots, PR good in scope.

Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@lijiarui lijiarui mentioned this pull request Jul 6, 2021
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change as I request, thanks!


You can run Wechaty on following platforms:
* [Google Cloud Shell](getting-started/quick-start.mdx)
* [Gitpod](getting-started/quick-start.mdx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinks we should add an anchor for Google Cloud Shell and Gitpod link.


You can run Wechaty on following platforms:
* [Google Cloud Shell](getting-started/quick-start.mdx)
* [Gitpod](getting-started/quick-start.mdx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinks we should add an anchor for Google Cloud Shell and Gitpod link.

Copy link
Member Author

@shwetalsoni shwetalsoni Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think providing the link to pages is better because a user needs to follow some steps to run ding-dong bot on gitpod and google cloud shell. Going directly to gitpod/google cloud shell link without knowing how to operate it will be inconvenient for the user.

Ps: we have changed the structure in #922 PR. Inside Quick start there will be 2 different pages for Gitpod and Google cloud shell. So once this PR is merged I'll update the links here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwetalsoni sure, could you file an issue illustrate this then we can tracking for this. Then I will approve this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @lijiarui , I have updated the status of this PR here

You can run Wechaty on following platforms:
* [Google Cloud Shell](getting-started/quick-start.mdx)
* [Gitpod](getting-started/quick-start.mdx)
* [Locally on your machine](getting-started/hard-way.mdx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change hard-way to running-locally after #888 changed as I requested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure, I'll change the file name to running-locally but here it can only be changed once #888 is merged

Wechaty is a powerful software. You will learn the following fundamental features of Wechaty in the getting-started tutorials:

* Turn a WeChat/Whatsapp account into a chatbot, a.k.a Conversational User Interface Automation Software, with just a few lines of code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove blank lines here.


* Work out of the box on Linux, Mac and Windows.

* Supports all [puppets](../puppet-services) like Web, Pad, Windows and Mac.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like Web, Pad, Windows and Mac. --> like Wechat, WhatsApp, WeCom, Lark and so on

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to like Wechat, WhatsApp, WeCom, Lark and so on

@shwetalsoni
Copy link
Member Author

shwetalsoni commented Jul 7, 2021

Hii @Rohitesh-Kumar-Jain @proudofsimin
I need some help with git. I accidently did git pull inside my new-getting-started branch and now the changes of others are also shown in my PR. I tried doing git revert to undo those but couldn't solve it. Can you please tell me how can i fix this.

@lijiarui
Copy link
Member

lijiarui commented Jul 8, 2021

@shwetalsoni You should change hard-way to running-locally, or the CI will keep red.

@shwetalsoni
Copy link
Member Author

@lijiarui I have turned the CI green.

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Looking forward to your new issue for tracking!

@shwetalsoni
Copy link
Member Author

@lijiarui I have mentioned this PR here in this issue #1032

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found you delete the following files, which is unrelated to this PR:

  • jekyll/_contributors/simplepad.md
  • jekyll/_posts/2021-06-17-puppet-simplepad-hello.md
  • jekyll/assets/2021/06-puppet-simplepad-hello/logo.png
  • jekyll/assets/2021/06-puppet-simplepad-hello/process.png
  • jekyll/assets/contributors/simplepad/avatar.png

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwetalsoni I found you delete the following files, which is unrelated to this PR, and it is a problem:

  • jekyll/_contributors/simplepad.md
  • jekyll/_posts/2021-06-17-puppet-simplepad-hello.md
  • jekyll/assets/2021/06-puppet-simplepad-hello/logo.png
  • jekyll/assets/2021/06-puppet-simplepad-hello/process.png
  • jekyll/assets/contributors/simplepad/avatar.png

Please recover these files. Please notice that each PR should not change other files

@lijiarui
Copy link
Member

lijiarui commented Jul 10, 2021

@shwetalsoni Since the .webp format has lots of advantages and the safari has supported it last year which means all the modern browsers will be able to compatible with it.

@huan has just added a new unit test for enforcing the image format: the CI will not be passed if we are using other image formats than the perfect .webp.

Please make CI green to adjust the new rule, see https://github.com/wechaty/wechaty.js.org/issues/1035

@shwetalsoni
Copy link
Member Author

@lijiarui I have restored the files and also added images in webp format.

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, after I look deep into the introduction, I think maybe we can modify more about the introduction, pls change as I request, thanks!

- [Gitpod](getting-started/quick-start.mdx)
- [Locally on your machine](getting-started/running-locally.mdx)

Wechaty is a powerful software. You will learn the following fundamental features of Wechaty in the getting-started tutorials:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change to the following saying instead of saying software, unify with Official Repo

Wechaty is a RPA (Robotic Process Automation) SDK for Chatbot Makers which can help you create a bot in 6 lines of [JavaScript](https://github.com/Wechaty/wechaty), [Python](https://github.com/Wechaty/python-wechaty/), [Go](https://github.com/Wechaty/go-wechaty/), and [Java](https://github.com/Wechaty/java-wechaty/), with cross-platform support including [Linux, Windows, MacOS](https://github.com/wechaty/wechaty/actions?query=workflow%3ANPM), and [Docker](https://github.com/wechaty/wechaty/actions?query=workflow%3ADocker).


Wechaty is a powerful software. You will learn the following fundamental features of Wechaty in the getting-started tutorials:

- Turn a WeChat/Whatsapp account into a chatbot, a.k.a Conversational User Interface Automation Software, with just a few lines of code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add more IM introduction here:

Turn different instant messaging (IM) systems (such as WeChat, Wecom,Whatsapp, Lark,Gitter, and TikTok) account into chatbot.

Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for the contribution!

@huan huan merged commit 00d0733 into wechaty:master Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoD 2021 tutorials Related to tutorial docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants