Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE v0.16 room.add return Promise<void> instead of return Promise<boolean> #1362

Closed
lijiarui opened this issue Jun 18, 2018 · 1 comment
Closed

BREAKING CHANGE v0.16 room.add return Promise<void> instead of return Promise<boolean> #1362

lijiarui opened this issue Jun 18, 2018 · 1 comment
Labels
breaking change
Milestone
v0.18 Connecting ...

Comments

@lijiarui
Copy link
Member

Berfore

Room.add(contact: Contact): Promise<boolean>

After

Room.add(contact: Contact): Promise<void>
@huan
Copy link
Member

huan commented Jun 19, 2018

BREAKING CHANGE room.add
->
BREAKING CHANGE v0.16 room.add

@lijiarui lijiarui changed the title BREAKING CHANGE room.add return Promise<void> instead of return Promise<boolean> BREAKING CHANGE v0.16 room.add return Promise<void> instead of return Promise<boolean> Jun 19, 2018
@huan huan closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
v0.18 Connecting with the Cloud & App
Development

No branches or pull requests
2 participants
@huan @lijiarui