feat: 🎸 channel #2525
Open
feat: 🎸 channel #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
huan
reviewed
Jun 2, 2023
| @@ -77,11 +77,11 @@ test('Wechaty Plugin uninstaller should be called after wechaty.stop()', async t | |||
|
|
|||
| test('isWechatyPluginUninstaller()', async t => { | |||
| const FIXTURES = [ | |||
| [undefined, false], | |||
| [() => {}, true], | |||
| [ undefined, false ], | |||
There was a problem hiding this comment.
Please create another PR to fix the linting problem.
We will be able to merge that PR very quickly so that this PR will be clearer.
Thanks!
| @@ -33,7 +33,7 @@ import { | |||
| test('findAll()', async t => { | |||
| const EXPECTED_NAME = 'TestingBot' | |||
|
|
|||
| const puppet = new PuppetMock() | |||
| const puppet = new PuppetMock() as any | |||
| @@ -1,3 +1,4 @@ | |||
| #!/usr/bin/env -S node --no-warnings --loader ts-node/esm | |||
| @@ -22,7 +22,7 @@ import { | |||
| Wechaty, | |||
| WechatyBuilder, | |||
| VERSION, | |||
| } from 'wechaty' | |||
| } from '@juzi/wechaty' | |||
There was a problem hiding this comment.
Please fix the non-community module in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #2467
由于其他相关 PR 还没合并， CI 暂时无法通过