Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Uploader is broken #23

Open
kraftner opened this issue Oct 20, 2016 · 2 comments
Open

Browser Uploader is broken #23

kraftner opened this issue Oct 20, 2016 · 2 comments
Assignees
Milestone

Comments

@kraftner
Copy link
Member

kraftner commented Oct 20, 2016

...because $_REQUEST['user_id'] is actually never set therefore this condition always fails.

The sad thing also is that the upload itself works, just the linking up with the user is skipped leaving an abandoned upload in the Media Library.

This could probably be fixed with a hidden user_idfield somewhere here but I haven't thought this through yet...

@franz-josef-kaiser franz-josef-kaiser added this to the 1.0.0 milestone Oct 20, 2016
@franz-josef-kaiser franz-josef-kaiser self-assigned this Oct 20, 2016
@franz-josef-kaiser
Copy link
Member

franz-josef-kaiser commented Oct 20, 2016

Labeled and assigned the milestone. Will look at it when I rework this plugin. In the meantime, I added you as collaborator with write access. This project is open for PRs :)

Sidenote: When linking on GitHub, please always press the Y key on your keyboard when looking at code so you link to a static commit to not make links a moving target when code evolves. Thank you!

@kraftner
Copy link
Member Author

Oh this happens if you don't do proper testing. This only happens when you edit your own profile. On other users user-edit screens user_id is added and everything works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants