Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thanks for your nice working! #2

Closed
ttlttc opened this issue May 31, 2021 · 40 comments
Closed

thanks for your nice working! #2

ttlttc opened this issue May 31, 2021 · 40 comments
Labels
enhancement New feature or request

Comments

@ttlttc
Copy link

ttlttc commented May 31, 2021 •
edited
Loading

little tired to write a bat file for bulk download with kh.py, your application just saved me!

hope there can auto receive links from kh's frontpage->'Latest Soundtracks' and add to linkbox in future~

search->add couldn't download directly

it add "/game-soundtracks/album/minecraft"
and hit "download" no effect
I must add url head "http://downloads.khinsider.com/game-soundtracks/album/minecraft" and download
@ttlttc
Copy link
Author

ttlttc commented May 31, 2021 •
edited
Loading

tested with
https://downloads.khinsider.com/game-soundtracks/album/vigilante-8-original-game-rip

no file downloaded.

@ttlttc
Copy link
Author

ttlttc commented May 31, 2021

when it contain lots of files
https://downloads.khinsider.com/game-soundtracks/album/dishonored-2-gamerip-2016

retry sometimes but still cannot download all 1096 files.

@weespin weespin added the bug Something isn't working label May 31, 2021
@weespin
Copy link
Owner

weespin commented May 31, 2021

Can confirm. There is a networking issue, working on a fix

@weespin
Copy link
Owner

weespin commented May 31, 2021 •
edited
Loading

Should be fixed in b56774c
I'll keep this issue open for ~2 days
Please report back if you'll find any errors

@weespin weespin added the enhancement New feature or request label May 31, 2021
@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021

alright, test with 2 links, everythings ok~

image

how about make search list larger?or fit window size

@weespin
Copy link
Owner

weespin commented Jun 1, 2021 •
edited
Loading

how about make search list larger?or fit window size

Just wait, i'll fix this

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021

image

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

Search form is now resizable
Audio Quality and select path buttons are disabled when downloading

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021

thanks,now I'll test bulk download.

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021 •
edited
Loading

  • save folder cannot remember on exit
  • when encounter error, display a dialog on task end?

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

  • save folder cannot remember on exit

It's actually working, i just forgot to update UI element

  • when encounter error, display a dialog on task end?

All errors are displayed in the log while downloading.

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

  • save folder cannot remember on exit

It's actually working, i just forgot to update UI element

Fixed

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

hope there can auto receive links from kh's frontpage->'Latest Soundtracks' and add to linkbox in future~

Can you explain this in more detail?
I can add this in ~30 minutes

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021 •
edited
Loading

like
image

image

and rip all links?

date labels are all 'h3' style,use regex to get links...maybe

but it's ok, i can do it myself

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021 •
edited
Loading

try to use html+js wrote a common link extractor
kh batch.zip

goto # a b c d...each page, copy the page source insider
image
and get all avaluable links

image

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

Oh, i'm asking about UI stuff

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

i can easily add recent albums into search box
But i don't know which albums i have to add?
Daily albums?

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021 •
edited
Loading

latest 10 update?

this area only shows on website's index page, not a single album.

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021 •
edited
Loading

no file DLed:
https://downloads.khinsider.com/game-soundtracks/album/3x3-eyes-seima-densetsu-matsuei-fudanshi-2-original-soundt

https://downloads.khinsider.com/game-soundtracks/album/3x3-eyes-seima-densetsu-matsuei-fudanshi-1-original-soundtra

page title:
3x3 Eyes - Seima Densetsu Matsuei Fudanshi 2 Original Soundt...

dot error?

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

no file DLed:
https://downloads.khinsider.com/game-soundtracks/album/3x3-eyes-seima-densetsu-matsuei-fudanshi-2-original-soundt

https://downloads.khinsider.com/game-soundtracks/album/3x3-eyes-seima-densetsu-matsuei-fudanshi-1-original-soundtra

caused by folder name length?

Can confirm, fixing 🔧

@weespin
Copy link
Owner

weespin commented Jun 1, 2021

dot error?

Yep!
Fixed

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021 •
edited
Loading

download finished with
https://downloads.khinsider.com/game-soundtracks/album/50-cent-bulletproof-2005-playstation-2

and discontinued

and...
why not give input textbox a vertical scrollbar too? only log have this lol

@weespin
Copy link
Owner

weespin commented Jun 1, 2021 •
edited
Loading

download finished with
https://downloads.khinsider.com/game-soundtracks/album/50-cent-bulletproof-2005-playstation-2

and discontinued

Please apply a full list of ulr's, i've dowloaded bulletproof successfully
explorer_qs6KHp5boh

why not give input textbox a vertical scrollbar too?

Fixed

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021

phew....already downloaded some hours and found nothing wrong, thanks again !

@ttlttc
Copy link
Author

ttlttc commented Jun 1, 2021

image

@ttlttc
Copy link
Author

ttlttc commented Jun 2, 2021

image

keep downloading more than 12hours, whole system get very slow....

@weespin
Copy link
Owner

weespin commented Jun 2, 2021

how much threads are you using?

@weespin
Copy link
Owner

weespin commented Jun 2, 2021

Also can you share a full list of url's?

@ttlttc
Copy link
Author

ttlttc commented Jun 2, 2021

long list.txt
10 threads
but it's cost looooooog times to download

@weespin
Copy link
Owner

weespin commented Jun 2, 2021 •
edited
Loading

Well, i think that parsing a html page/UI calls are very cpu intensive.
Now you can tune downloading performance using Album Threads/Threads numboxes and use supress logs checkbox to reduce CPU usage.
I can easily get 250 Mb/s using 2 album threads and 4 usual threads
Taskmgr_RCUzMlw0fj
My personal record is ~500 Mb/s but i forgot to screenshot it 😂.

@ttlttc
Copy link
Author

ttlttc commented Jun 2, 2021

okay, I think it's a good solution for low-performance computer

@ttlttc
Copy link
Author

ttlttc commented Jun 2, 2021

trying to use 1album 2threads, even cpu usage is high too,at least title and log not laggy.

@ttlttc
Copy link
Author

ttlttc commented Jun 2, 2021

hmm.system hang again, better not insert too more links at one time ,hah

@ttlttc
Copy link
Author

ttlttc commented Jun 2, 2021 •
edited
Loading

https://downloads.khinsider.com/game-soundtracks/album/addams-family

couldnot download on new version

image

@weespin
Copy link
Owner

weespin commented Jun 3, 2021

couldnot download on new version

Fixed

Number?

Chinese font issue

@ttlttc
Copy link
Author

ttlttc commented Jun 3, 2021 •
edited
Loading

Chinese font issue

number box right align?

--

image

is there a way to make all file downloaded then show 'album finished'?
I know maybe it caused by multi-thread

@ttlttc
Copy link
Author

ttlttc commented Jun 10, 2021

seems audio quality is not work
https://downloads.khinsider.com/game-soundtracks/album/rockman-sound-box-shooting-star

"best" still downloaded mp3 files

@AlanBTG
Copy link

AlanBTG commented Oct 27, 2021

Can confirm. Khinsider 2.5.0.0 only downloads .mp3's with Best option selected and FLAC versions available.

@weespin
Copy link
Owner

weespin commented Oct 27, 2021

Will fix in 48hrs

@weespin
Copy link
Owner

weespin commented Oct 28, 2021

Will fix in 48hrs

Fixed in e4b0a77

@weespin weespin removed the bug Something isn't working label Oct 28, 2021
@weespin weespin closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlanBTG @weespin @ttlttc