From 716cf5c82c460b1f0411bdc72f2fda356ee7f621 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Weslley=20Ara=C3=BAjo?=
 <46850407+wellwelwel@users.noreply.github.com>
Date: Wed, 26 Jun 2024 04:14:49 -0300
Subject: [PATCH] fix(beforeEach and afterEach): end with the proper exit code
 (#471)

---
 src/services/each.ts                   |   2 -
 test/e2e/before-and-after-each.test.ts | 103 ++++++++++++++++++++++---
 2 files changed, 92 insertions(+), 13 deletions(-)

diff --git a/src/services/each.ts b/src/services/each.ts
index e12470a9..2a0ac718 100644
--- a/src/services/each.ts
+++ b/src/services/each.ts
@@ -42,7 +42,6 @@ const eachCore = async (
     /* c8 ignore stop */
 
     return true;
-    /* c8 ignore start */
   } catch (error) {
     write(
       format(`    ✘ ${type} callback failed ${format(`› ${cb}`).dim()}`)
@@ -61,7 +60,6 @@ const eachCore = async (
 
     return false;
   }
-  /* c8 ignore stop */
 };
 
 export const beforeEach = async (fileRelative: string, configs?: Configs) => {
diff --git a/test/e2e/before-and-after-each.test.ts b/test/e2e/before-and-after-each.test.ts
index c120f946..f3cc7c91 100644
--- a/test/e2e/before-and-after-each.test.ts
+++ b/test/e2e/before-and-after-each.test.ts
@@ -7,7 +7,10 @@ import { assert } from '../../src/modules/assert.js';
 test(async () => {
   const prepareService = () => new Promise((resolve) => resolve(undefined));
   const resetService = () => new Promise((resolve) => resolve(undefined));
-  // const crashIt = () => new Promise((_, reject) => reject("Let's crash it"));
+  const crashIt = () => new Promise((_, reject) => reject("Let's crash it"));
+  const crashItAgain = () => {
+    throw new Error("Let's crash it");
+  };
 
   await describe('Before and After Each: direct methods', async () => {
     await it(async () => {
@@ -18,7 +21,7 @@ test(async () => {
         afterEach: resetService,
       });
 
-      assert.equal(
+      assert.strictEqual(
         code,
         0,
         'beforeEach and afterEach hooks with successful path'
@@ -33,7 +36,11 @@ test(async () => {
         afterEach: resetService,
       });
 
-      assert.equal(code, 1, 'beforeEach and afterEach hooks with failing path');
+      assert.strictEqual(
+        code,
+        1,
+        'beforeEach and afterEach hooks with failing path'
+      );
     });
   });
 
@@ -46,7 +53,7 @@ test(async () => {
         afterEach: () => resetService(),
       });
 
-      assert.equal(
+      assert.strictEqual(
         code,
         0,
         'beforeEach and afterEach hooks with successful path'
@@ -61,7 +68,11 @@ test(async () => {
         afterEach: () => resetService(),
       });
 
-      assert.equal(code, 1, 'beforeEach and afterEach hooks with failing path');
+      assert.strictEqual(
+        code,
+        1,
+        'beforeEach and afterEach hooks with failing path'
+      );
     });
   });
 
@@ -74,7 +85,7 @@ test(async () => {
         afterEach: async () => await resetService(),
       });
 
-      assert.equal(
+      assert.strictEqual(
         code,
         0,
         'beforeEach and afterEach hooks with successful path'
@@ -89,7 +100,11 @@ test(async () => {
         afterEach: async () => await resetService(),
       });
 
-      assert.equal(code, 1, 'beforeEach and afterEach hooks with failing path');
+      assert.strictEqual(
+        code,
+        1,
+        'beforeEach and afterEach hooks with failing path'
+      );
     });
   });
 
@@ -102,7 +117,7 @@ test(async () => {
         afterEach: () => true,
       });
 
-      assert.equal(
+      assert.strictEqual(
         code,
         0,
         'beforeEach and afterEach hooks with successful path'
@@ -117,7 +132,11 @@ test(async () => {
         afterEach: () => true,
       });
 
-      assert.equal(code, 1, 'beforeEach and afterEach hooks with failing path');
+      assert.strictEqual(
+        code,
+        1,
+        'beforeEach and afterEach hooks with failing path'
+      );
     });
   });
 
@@ -136,7 +155,7 @@ test(async () => {
         },
       });
 
-      assert.equal(
+      assert.strictEqual(
         code,
         0,
         'beforeEach and afterEach hooks with successful path'
@@ -157,7 +176,69 @@ test(async () => {
         },
       });
 
-      assert.equal(code, 1, 'beforeEach and afterEach hooks with failing path');
+      assert.strictEqual(
+        code,
+        1,
+        'beforeEach and afterEach hooks with failing path'
+      );
+    });
+  });
+
+  await describe('Before and After Each: Failure', async () => {
+    await it(async () => {
+      const code = await poku('./fixtures/success', {
+        noExit: true,
+        quiet: true,
+        beforeEach: crashIt,
+        afterEach: resetService,
+      });
+
+      assert.strictEqual(
+        code,
+        1,
+        'Rejects beforeEach hook with successful path'
+      );
+    });
+
+    await it(async () => {
+      const code = await poku('./fixtures/success', {
+        noExit: true,
+        quiet: true,
+        beforeEach: prepareService,
+        afterEach: crashIt,
+      });
+
+      assert.strictEqual(
+        code,
+        1,
+        'Rejects afterEach hook with successful path'
+      );
+    });
+
+    await it(async () => {
+      const code = await poku('./fixtures/success', {
+        noExit: true,
+        quiet: true,
+        beforeEach: crashItAgain,
+        afterEach: resetService,
+      });
+
+      assert.strictEqual(
+        code,
+        1,
+        'Throws beforeEach hook with successful path'
+      );
+    });
+
+    await it(async () => {
+      const code = await poku('./fixtures/success', {
+        noExit: true,
+        quiet: true,
+        beforeEach: prepareService,
+        afterEach: crashItAgain,
+      });
+
+      assert.strictEqual(code, 1, 'Throws afterEach hook with successful path');
     });
   });
 });