Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing image links for project pages #152

Closed
donovanglover opened this issue Sep 13, 2023 · 8 comments · Fixed by #157
Closed

Missing image links for project pages #152

donovanglover opened this issue Sep 13, 2023 · 8 comments · Fixed by #157
Assignees

Comments

@donovanglover
Copy link
Contributor

Bug Report

Environment

Zola version: 0.17.2
tabi commit: f1d92a7

Expected Behavior

Images should be clickable for project pages.

Current Behavior

Images are only clickable if page.extra.link_to is used.

Step to reproduce

{% if page.extra.link_to %}
<a rel="{{ rel_attributes }}" {{ blank_target }} href={{ page.extra.link_to }}>
{% endif %}

@welpo
Copy link
Owner

welpo commented Sep 13, 2023

Where would the image lead to, if there's no external URL? To the pages that are built for each project?

@donovanglover
Copy link
Contributor Author

page.permalink would be ideal since they get auto-generated.

@welpo
Copy link
Owner

welpo commented Sep 13, 2023

Makes sense. I always thought of the auto-generated pages as a nuisance, but I guess they could be used as a post to explain the project (with the default article template or with the new info-page.html).

On it!

@welpo welpo self-assigned this Sep 13, 2023
@donovanglover
Copy link
Contributor Author

There could be optional icons or text below the project name such as GitHub, Demo Website, etc.

This would replace link_to.

@welpo
Copy link
Owner

welpo commented Sep 13, 2023

There could be optional icons or text below the project name such as GitHub, Demo Website, etc.

On the project's .md file, you mean, right? (i.e. the example you linked from my site)

@donovanglover
Copy link
Contributor Author

I think the project page is better than the listing to avoid giving the user too many choices. This also drives traffic to the project pages.

@welpo
Copy link
Owner

welpo commented Sep 15, 2023

Done in #157!

@donovanglover
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants