🐛 fix(comments): fix malformed URLs in Isso mails #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address the issue of malformed URLs in the email notifications generated by Isso, as detailed in #210.
Changes
data-isso-id
anddata-title
are set.Implementation details
The previous setup used the page's slug to populate
data-isso-id
anddata-title
. This resulted in URLs lacking a separating slash between the domain and the identifier/post in the email notifications.The new setup uses
default_lang_url
in Tera templates to populate these attributes:Limitations
While this solution is effective for most use-cases, it's not perfect. Specifically, if a post does not exist in a non-default language, the URL in the email notification will still return 404. However, as far as I know, this is the only way to merge comments in multilingual sites effectively.
Testing
page_id_is_slug = true
in[extra.isso]
.