🐛 fix(i18n): atom feed page direction for RTL langs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAwiteb
changed the title
TheAwiteb
force-pushed
the
fix-feed-page-rtl-diraction
branch
from
dc7ea85 to
f0a93fd
Compare
TheAwiteb
changed the title
TheAwiteb
force-pushed
the
fix-feed-page-rtl-diraction
branch
from
f0a93fd to
b34ca2d
Compare
|
Thank you! |
|
I'm curious, did you test if this |
It's should work, but in Arabic and I think also in other languages we (as individuals) may start the line with English word, so this will destroy the entire page. If
|
|
Awesome! Thanks for testing and for the clear explanation!! 🫶 |
Smtbook
pushed a commit
to Smtbook/zola-theme-tabi
that referenced
this pull request
Feb 29, 2024
Co-authored-by: welpo <welpo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #267
The page will looks like this after this PR
Note
I change the language from English to Arabic, to see the page in
LTRandRTL2024-02-11.19-25-16.mp4