Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 refactor: improve last_updated_on format #342

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Jun 28, 2024

Summary

Changes the last_updated_on i18n string to (1) include a $DATE placeholder and (2) be less verbose.

The placeholder is useful for languages like Japanese. Before, all languages were forced to the last_updated_on string + $date structure. The new format improves translation accuracy.

Related issue

Idea from #330.

Changes

  • Update i18n strings
  • Implement $DATE placeholder replacement

Accessibility

Remains the same.

Screenshots

Old

Last updated on $DATE

New

Updated on $DATE

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added enhancement New feature or request i18n Internationalisation labels Jun 28, 2024
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit f0501e6
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/667eed12e233af000873cf2f
😎 Deploy Preview https://deploy-preview-342--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit 3bb2dbc into main Jun 28, 2024
4 checks passed
@welpo welpo deleted the refactor/updated-date-string branch June 28, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant