Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style(error): enhance visibility of Zola errors #359

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

welpo
Copy link
Owner

@welpo welpo commented Jul 24, 2024

Summary

This PR introduces minimal CSS styling to enhance the visibility of Zola error messages during development. It centers the error messages both vertically and horizontally on the screen and applies consistent styling using theme variables.

CSS specificity should target only Zola errors and not affect user content.

Changes

  • Added a new SCSS file zola-error.scss to style Zola error messages
  • Positioned error messages in the center of the viewport
  • Applied theme-consistent colors using existing CSS variables
  • Improved readability of error messages

Accessibility

The changes improve the visibility of error messages, which enhances the overall accessibility of the development process. The centered position and improved contrast make the messages easier to notice and read for all users.

Screenshots

Before

Hard to see, at the very bottom of the page, below the footer:

before

After

Floating, centered:

after

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the enhancement New feature or request label Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit fff8e65
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66a1406e301e5800084544f3
😎 Deploy Preview https://deploy-preview-359--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit 89d3544 into main Jul 24, 2024
8 checks passed
@welpo welpo deleted the style/zola-errors branch July 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant