Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json not always updated for monorepo with Lerna #39

Closed
loremaps opened this issue Jun 7, 2019 · 6 comments
Closed

package.json not always updated for monorepo with Lerna #39

loremaps opened this issue Jun 7, 2019 · 6 comments

Comments

@loremaps
Copy link
Contributor

loremaps commented Jun 7, 2019

Many thanks for this script 👍 !

I have a lerna monorepo and the MRs do not always include updates for the package.json files. The dependencies seems to be tracked correctly and the package-lock.json files are always updated.

For example:
image
Here only one package.json got updated, although both packages have exactly the same version. The other was not updated.

For other dependencies I get only updates on the package-lock.json only.
For some other dependency everything got updated correctly.

Any ideas? Should I report this upstream?

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2019

Yes, this is a dependabot-core issue. Thanks for reporting!
I am planning to use lerna soon.

@greysteil
Copy link

This will be because of the update strategy you're using here. If you want Dependabot to always update your package.json set bump_versions as the update strategy.

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2019

Will do! @greysteil thanks for your help!

@greysteil
Copy link

No worries! For reference, the current possible strategies are:

{
  "npm_and_yarn" => %w(auto widen_ranges bump_versions bump_versions_if_necessary),
  "composer" => %w(auto widen_ranges bump_versions bump_versions_if_necessary),
  "dep" => %w(auto widen_ranges bump_versions),
  "bundler" => %w(auto bump_versions bump_versions_if_necessary),
}

@sobolevn
Copy link
Member

sobolevn commented Jun 7, 2019

@loremaps feel free to reopen if something does not work for you. 👍

@loremaps
Copy link
Contributor Author

loremaps commented Jun 7, 2019

Many thanks @sobolevn and @greysteil. Just a small fix in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants