From 6fe30ee7d0cda0c539f46ee863c033d7e54dba6c Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Thu, 29 Mar 2018 14:24:11 -0700 Subject: [PATCH] Add missing perms to sql_lab role (#4714) The SQL Lab related role that is created programmatically is missing permissions that make SQL Lab functional. --- superset/security.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/superset/security.py b/superset/security.py index 8ea91b941561e..e342b034d99cc 100644 --- a/superset/security.py +++ b/superset/security.py @@ -349,9 +349,14 @@ def is_gamma_pvm(self, pvm): self.is_alpha_only(pvm)) def is_sql_lab_pvm(self, pvm): - return pvm.view_menu.name in {'SQL Lab'} or pvm.permission.name in { - 'can_sql_json', 'can_csv', 'can_search_queries', - } + return ( + pvm.view_menu.name in { + 'SQL Lab', 'SQL Editor', 'Query Search', 'Saved Queries', + } or + pvm.permission.name in { + 'can_sql_json', 'can_csv', 'can_search_queries', 'can_sqllab_viz', + 'can_sqllab', + }) def is_granter_pvm(self, pvm): return pvm.permission.name in {