-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime] support onnxruntime #135
Conversation
speed: RTF
|
The speaker_api(c++) is related to business, so we don't consider adding this code for now. |
runtime/core/speaker/e2e_speaker.h
Outdated
|
||
namespace wespeaker { | ||
|
||
class E2ESPEAKER { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2eSpeaker, the name convention should be consistent to global code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
runtime/core/speaker/e2e_speaker.h
Outdated
|
||
class E2ESPEAKER { | ||
public: | ||
explicit E2ESPEAKER(const std::string& model_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, we do not add const & for basic types, such as int/float/double.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Great job! |
This PR is about the implementation of runtime, based on onnxruntime(cpu).
api (c++)