Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

API Changes / Segregation #66

Open
1 task
jreback opened this issue Dec 22, 2016 · 3 comments
Open
1 task

API Changes / Segregation #66

jreback opened this issue Dec 22, 2016 · 3 comments

Comments

@jreback
Copy link

jreback commented Dec 22, 2016

This will serve as a master issue to record API changes / testing that needs segregation in pandas.

Copy-on-write can help here:

@wesm
Copy link
Owner

wesm commented Dec 22, 2016

As a matter of process, the way this should probably work is:

  • Segregate unit tests subject to breakage in upstream pandas-dev/pandas
  • Rebase pandas2 on upstream branch.
  • Write new unit tests that port those "bad" tests to new tests that reflect the changed behavior

what do you think?

@jreback
Copy link
Author

jreback commented Dec 22, 2016

yep, should have the test runner exclude them for pandas2 (and add separate tests that only) apply to pandas 2.

so prob need something like

pandas/tests # existing tests
pandas/tests_changing_in_pandas2
pandas/tests_pandas2

with the sub-structure the same as

pandas/tests

but the changing/pandas2 can live on pandas2 repo

@jorisvandenbossche
Copy link
Contributor

From the dev meeting: idea is instead of physically segregating the tests is to leave them at the same place but mark them as "may fail on pandas 2.0"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants