You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This triggers the following warning in Chrome's console:
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.
The warning from Chrome is a bit off...since you are testing ev.returnValue, and not setting it, using ev.preventDefault() isn't really the right answer.
I'm not experienced with javascript and events, so I didn't create this as a pull request, but the following seems like it would fix the issue with as little additional code as possible:
"returnValue" in ev && returnValue = ( ev.returnValue === YES ); break;:
Also, thanks for writing defer.js...we're using it in development for a revamped version of one of our ecommerce sites. The boost in page load times is significant, and I found this much easier to use than the other javascript async loaders I tried.
The text was updated successfully, but these errors were encountered:
Just noticed my fix only quiets the first complaint from chrome at page load time, but it complains later if an event fires. Confirms my lack of experience in that area :)
Line 623 of the current source has this:
returnValue = ( ev.returnValue === YES ); break;
This triggers the following warning in Chrome's console:
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.
The warning from Chrome is a bit off...since you are testing ev.returnValue, and not setting it, using ev.preventDefault() isn't really the right answer.
I'm not experienced with javascript and events, so I didn't create this as a pull request, but the following seems like it would fix the issue with as little additional code as possible:
"returnValue" in ev && returnValue = ( ev.returnValue === YES ); break;:
Also, thanks for writing defer.js...we're using it in development for a revamped version of one of our ecommerce sites. The boost in page load times is significant, and I found this much easier to use than the other javascript async loaders I tried.
The text was updated successfully, but these errors were encountered: