Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add handler tests in paper #123

Merged
merged 3 commits into from
Dec 6, 2024
Merged

test: add handler tests in paper #123

merged 3 commits into from
Dec 6, 2024

Conversation

penqee
Copy link
Contributor

@penqee penqee commented Dec 3, 2024 •
edited
Loading

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>
  • 此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
  • 我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
  • 这个 PR 属于强制变更/破坏性更改

如果是，请在 PR 标题中添加 BREAKING CHANGE 前缀，并在 PR 描述中详细说明。

这个 PR 的类型是什么？

这个 PR 做了什么 / 我们为什么需要这个 PR？

handler缺乏测试代码，这个PR是对paper_service的handler进行测试

(可选)这个 PR 解决了哪个/些 issue？

对 Reviewer 预留的一些提醒

  1. 对handler的测试拿不准，目前主要是参考了gin和Hertz給出的测试代码，可能还有不少需要改进的地方

@penqee penqee requested review from jiuxia211, ozline and a team as code owners December 3, 2024 03:03
@penqee penqee changed the title [WIP] test: add handler tests in paper test: add handler tests in paper Dec 5, 2024
@jiuxia211 jiuxia211 merged commit 8ceae71 into west2-online:main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiuxia211 jiuxia211 jiuxia211 approved these changes

@ozline ozline Awaiting requested review from ozline ozline is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penqee @jiuxia211