fix: add addressing error example in examroom module #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchwarzSail
requested review from
jiuxia211,
ozline and
a team
as code owners
jiuxia211
reviewed
Dec 7, 2024
internal/classroom/handler.go
Outdated
| @@ -84,7 +84,7 @@ func (s *ClassroomServiceImpl) GetExamRoomInfo(ctx context.Context, req *classro | |||
| resp = classroom.NewExamRoomInfoResponse() | |||
| rooms, err := service.NewClassroomService(ctx, s.ClientSet).GetExamRoomInfo(req) | |||
| if err != nil { | |||
| logger.Infof("Classroom.GetExamRoomInfo: Get exam room info fail %v", err) | |||
| logger.Errorf("Classroom.GetExamRoomInfo: Get exam room info fail %v", err) | |||
There was a problem hiding this comment.
cookie 过期的错误是经常出现的，用 logger.Errorf 是不是不合适？
There was a problem hiding this comment.
统一一下吧：业务错误使用 Info，其他的错误用 error 吧
There was a problem hiding this comment.
There was a problem hiding this comment.
的确，这样普通运行的时候v 设置小一点，使得只记录必要的错误
调试的时候增大 v 就可以显示更多信息，没有毛病
不过你有没有想过这里用 Debug 和用 Info 的区别？@SchwarzSail
没有）求科普
There was a problem hiding this comment.
的确，这样普通运行的时候v 设置小一点，使得只记录必要的错误
调试的时候增大 v 就可以显示更多信息，没有毛病
不过你有没有想过这里用 Debug 和用 Info 的区别？@SchwarzSail没有）求科普
在日志初始化的时候 Logger 对象有一个变量叫 LogLevel，他只会打印大于这个 Level 的日志。
比如你的 logger 的 LogLevel 为 Info，那么他会打印出 info。
但是你的 LogLevel 为 debug 的话，因为他会打印出 info 和 debug，因为 debugLevel 等级更低，所以他会打印所有大于这个等级的日志。
同理，如果你的 Level 为 Error，那么下面这个将什么都不会输出，因为 Error > Warning > Info > Debug
logger.Info("info")
logger.Debug("debug")
|
@mutezebra cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自查 PR 结构
PR 标题符合这个格式: <type>(optional scope): <description>
此 PR 标题的描述以用户为导向，足够清晰，其他人可以理解。
我已经对所有 commit 提供了签名（GPG 密钥签名、SSH 密钥签名）
这个 PR 属于强制变更/破坏性更改
这个 PR 的类型是什么？
这个 PR 做了什么 / 我们为什么需要这个 PR？
在 examroom 模块添加了错误的处理流程：
logger.Errorfpack.RespError(c, err)(可选)这个 PR 解决了哪个/些 issue？
对 Reviewer 预留的一些提醒