build.rs: warn if cbordiag tools are not found #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of panicking at built time, just warn about the cbor tools not being found. At run-time, `spdm-utils` will return an error when attempting decode a cbor encoded manifest from a responder. This should not affect a responder as we already have pre-generated manifests checked in the `manifests/` directory. Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of panicking at built time, just warn about the cbor tools not
being found. At run-time,
spdm-utilswill return an error whenattempting decode a cbor encoded manifest from a responder.
This should not affect a responder as we already have pre-generated
manifests checked in the
manifests/directory.The primary motivation for this is to allow the
Buildrootpackage to be upstream friendly.