spdm_transport: generic: refactor IO buffers #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twilfredo
force-pushed
the
wilfred/refactor_io_buffers
branch
from
d7cf66f to
8fe1a25
Compare
|
to go in after #119 |
twilfredo
force-pushed
the
wilfred/refactor_io_buffers
branch
from
8fe1a25 to
44b76c7
Compare
Base automatically changed from
wilfred/make-ruby-deps-optional
to
wilfred/bump-libspdm-3.5.0
November 8, 2024 00:08
alistair23
requested changes
Nov 8, 2024
This allows us to remove alot of repeated code for buffer `set/get`. This approach uses a heap allocated vector and just passes a reference to `libspdm` when required. The associated memory shall be explicitly freed by taking ownership when the buffers are no longer required. Which can be done by calling `libspdm_drop_io_buffers()`. Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
twilfredo
force-pushed
the
wilfred/refactor_io_buffers
branch
from
44b76c7 to
05a7aed
Compare
alistair23
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove alot of repeated code for buffer
set/get. This approach uses a heap allocated vector and just passes a reference tolibspdmwhen required.The associated memory shall be explicitly freed
by taking ownership when the buffers are no longer required. Which can be done by calling
libspdm_drop_io_buffers().