Add dynamic image measurement #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this is overlay complicated, but it's hard to integrate it with the C libspdm callbacks and the Rust libspdm crate |
alistair23
force-pushed
the
alistair/hash-operation
branch
from
13331c9 to
ce3f597
Compare
|
#96 should be merged first to fix the CI first |
twilfredo
approved these changes
Jul 30, 2024
alistair23
force-pushed
the
alistair/hash-operation
branch
2 times, most recently
from
b3b5028 to
6931c2c
Compare
twilfredo
requested changes
Jul 31, 2024
Add a command line argument for responders to enable dynamic image measurement. This allows us to more accuratly model a real respnoder. At startup we spawn two threads to hash the "kernel" and the application. We currently join them before running the responder, we actually only need to do this before generating the measurement, but there isn't a nice way to do that from the libspdm Rust library. I thought of a closure callback, but it's all a bit messy so the current approach will do for now. `libspdm_fill_measurement_image_hash_block()` will now dynamically use a type of image block based on the init status of the `Lazy` `DYN_IMAGE_MEASURE`. Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
…cate_to_nvm Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
alistair23
force-pushed
the
alistair/hash-operation
branch
from
6931c2c to
9bc31eb
Compare
twilfredo
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command line argument for responders to enable dynamic image measurement. This allows us to more accuratly model a real respnoder.
At startup we spawn two threads to hash the "kernel" and the application. We currently join them before running the responder, we actually only need to do this before generating the measurement, but there isn't a nice way to do that from the libspdm Rust library. I thought of a closure callback, but it's all a bit messy so the current approach will do for now.
libspdm_fill_measurement_image_hash_block()will now dynamically use a type of image block based on the init status of theLazyDYN_IMAGE_MEASURE.