Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chain): updated nativeCurrency decimal for defichainEvmTestnet and defichainEvm #2366

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

fullstackninja864
Copy link
Contributor

@fullstackninja864 fullstackninja864 commented Jun 4, 2024

This PR update nativeCurrency decimal for defichainEvm (mainnet) and defichainEvmTestnet (testnet) chain definition.

Detailed summary
We are getting this error while connecting to defichainEvm/defichainEvmTestnet network (as below)
This issue is related to miss match with decimal place.

MetaMask - RPC Error: Expected the number 18 for 'nativeCurrency.decimals' when 'nativeCurrency' is provided. Received: 8 {code: -32602, message: "Expected the number 18 for 'nativeCurrency.decimals' when 'nativeCurrency' is provided. Received: 8", stack: '{\n  "code": -32602,\n  "message": "Expected the num…ogaeaoehlefnkodbefgpgknn/background-4.js:3:56371)'}

PR-Codex overview

This PR updates the decimals for DeFiChain from 8 to 18 in defichainEvm.ts and defichainEvmTestnet.ts, and also adjusts the nativeCurrency for these chains.

Detailed summary

  • Updated decimals for DeFiChain from 8 to 18 in defichainEvm.ts and defichainEvmTestnet.ts
  • Adjusted nativeCurrency for defichainEvmTestnet and defichainEvm

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: e22c41b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 4, 2024

@fullstackninja864 is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit 561b03a into wevm:main Jun 4, 2024
12 of 26 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants