Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extended client action composition #2675

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

holic
Copy link
Sponsor Contributor

@holic holic commented Aug 30, 2024

I wanted to know how client extending/action composition was meant to work, so I wrote a test to demonstrate since it doesn't seem to be documented anywhere.

(This is my assumed behavior and the test confirms it!)


PR-Codex overview

The focus of this PR is to add a test for action composition in the createClient function.

Detailed summary

  • Added a test for action composition in createClient
  • Imported getChainId function for testing
  • Added getAction utility function for action composition in tests

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 30, 2024

⚠️ No Changeset found

Latest commit: c966474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 30, 2024

@holic is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@holic holic marked this pull request as ready for review August 30, 2024 18:14
@holic holic changed the title test: client action composition test: extended client action composition Aug 30, 2024
@holic holic force-pushed the holic/action-composition-test branch from d921403 to c966474 Compare August 30, 2024 18:16
@jxom jxom merged commit b261491 into wevm:main Aug 31, 2024
21 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants