Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the lower or upper bounds are a value of zero, this check just nulls them out #70

Open
aaroncox opened this issue Jun 16, 2024 · 1 comment · May be fixed by #71
Open

If the lower or upper bounds are a value of zero, this check just nulls them out #70

aaroncox opened this issue Jun 16, 2024 · 1 comment · May be fixed by #71

Comments

@aaroncox
Copy link
Member

contract/src/utils.ts

Lines 62 to 64 in eec0425

if (!value) {
return
}

This prevents a JS value of 0 from being used in the query. It just sets those fields as empty values. We need a better check here to get around these things that are false-y in JS.

@SleepingProgrammer
Copy link

Thank you for documenting this 🙇‍♂️
Just gonna comment to follow this issue until it gets fixed so I can update the workaround I made.

aaroncox added a commit that referenced this issue Jun 17, 2024
@aaroncox aaroncox linked a pull request Jun 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants