Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for 4.0.3 #737

Merged
merged 2 commits into from
Mar 26, 2023
Merged

updates for 4.0.3 #737

merged 2 commits into from
Mar 26, 2023

Conversation

aw-was-here
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 26, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.24%.

Quality metrics Before After Change
Complexity 7.10 ⭐ 7.20 ⭐ 0.10 👎
Method Length 106.56 🙂 107.31 🙂 0.75 👎
Working memory 6.66 🙂 6.66 🙂 0.00
Quality 63.34% 🙂 63.10% 🙂 -0.24% 👎
Other metrics Before After Change
Lines 813 819 6
Changed files Quality Before Quality After Quality Change
nowplaying/db.py 63.96% 🙂 63.96% 🙂 0.00%
nowplaying/imagecache.py 62.99% 🙂 62.62% 🙂 -0.37% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nowplaying/imagecache.py ImageCache.queue_process 30 😞 226 ⛔ 16 ⛔ 23.75% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nowplaying/db.py MetadataDB.write_to_metadb 12 🙂 216 ⛔ 44.04% 😞 Try splitting into smaller methods
nowplaying/db.py create_setlist 9 🙂 262 ⛔ 10 😞 45.91% 😞 Try splitting into smaller methods. Extract out complex expressions
nowplaying/imagecache.py ImageCache.image_dl 3 ⭐ 211 ⛔ 9 🙂 56.68% 🙂 Try splitting into smaller methods
nowplaying/imagecache.py ImageCache.fill_queue 6 ⭐ 149 😞 10 😞 57.09% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@aw-was-here aw-was-here merged commit 8d530aa into main Mar 26, 2023
@aw-was-here aw-was-here deleted the prepare-4.0.3 branch March 26, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant