-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferred fetching feedback #1715
Comments
How do I do that synchronously? I basically want to allow only HTTPS+localhost-ish and throw immediately if that's not the case. |
... Fixed everything else. |
Regarding
Suggesting |
How about Let me also copy in @domenic as the person having last touched timers in HTML and likely having relevant opinions. |
Actually it would be |
[copying from Matrix] The reason why I like The fetch could be activated after the deadline or before, but for different reasons. The timeout duration is like a preference. The UA would activate before the timeout in case of termination or some such, and after the activation timeout for throttling/batching. The word "timeout" is maybe confusing because it's the opposite of the abort signal's timeout |
I was asked to provide feedback but since I have been purposefully not paying attention to the giant thread #1647, I don't have much to provide. For example I have no idea what "activation" or "activate" concept is being discussed. I'm happy to leave this to my colleagues, as I don't think the value I can provide here is outweighed by the amount of time it would take me to get up to speed on this API. |
I think this is the main remaining issue. @mingyc what is the model for this in chromium? Do we use the |
I thought we should use permission policy as described in WICG/pending-beacon#77. The proposal is by default it should be enabled. It is currently not implemented in chromium though. Unrelated to this topic, but |
After some offline discussions, we think it's fine to remove this check for now, as there is currently no permissions policy defined for other keepalive requests (fetch, sendBeacon()). We we get more feedback about providing control on this, the policy should be implemented not just for FetchLater, but for other keepalive requests. |
OK, as discussed at TPAC, sending a |
Is there some record of the TPAC discussion? I don't understand why we would ever deny a call to If someone wants to propose a permissions policy that controls all keep-alive-like fetches, that would be consistent. I would also want to understand why that would be desirable. |
It's here, though I didn't participate in this discussion. |
I don't see anything about that there. Maybe it happened outside the room. Do you know who suggested it? |
It came up in the WHATNOT meeting last week as something that was raised in TPAC. Finding out. I'm OK with not having this restriction. |
I thought this capability was going to be more powerful than It was with the understanding that it was going to be more powerful that the idea came up that it perhaps should be constrained in some manner. Also, |
It is no more powerful in the sense that there is no new information that you can extract with this API. It is more reliable and as a result can reduce the number of requests made since now you can safely allow data to accumulate instead of eagerly shipping it home, knowing that it will be sent. If we restrict this, devs are just going to use Is there a specific concern that you are trying to guard against? |
Allowing fetches beyond the lifetime of the top-level navigable is a big deal and we're not willing to give unfettered access to it. Because that will impact overall system performance. Giving unfettered access to this from the least trusted documents within a website by default seemed like a non-starter and when we discussed this way-back-when with @yoavweiss we said as much. Permission policy delegation seems reasonable, but there will have to be some kind of upper limit. |
The TPAC discussion did not include anything on limiting this to top-level origin, and I don't remember this being discussed. IIRC in the past we talked about restricting this behind a background fetch permission, as both have similar characteristics. We also discussed an upper limit per beacon origin, to avoid sharing a quota amongst different origins. |
I'm not talking about TPAC, I'm talking about the discussion we had when this was still |
We use background sync permission WICG/pending-beacon#3 (comment) to decide whether a fetchLater can stay after navigation.
We didn't have discussion about restricting with permission policy until moving toward fetch-based approach. There is a tracking issue with no feedback WICG/pending-beacon#77 |
Feedback on #1647 to keep the overall PR in terms of comments and such somewhat smaller in size.
fetch()
, but to the fact that the method can fetch. So "FetchLater method" doesn't make a whole lot of sense in that light.FetchLaterResult
needs to be[Exposed]
.DOMException
that should follow the style for them.<hr>
before the deferred fetch record definition.fetchLater()
and some inside "request a deferred fetch"?The text was updated successfully, but these errors were encountered: