Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointer to HTML about top layer and inertness #15

Open
annevk opened this issue Jul 15, 2015 · 2 comments
Open

Add pointer to HTML about top layer and inertness #15

annevk opened this issue Jul 15, 2015 · 2 comments
Labels
clarification Standard could be clearer

Comments

@annevk
Copy link
Member

annevk commented Jul 15, 2015

Once HTML defines how being on top of the top layer affects inertness, there should be a pointer from Fullscreen.
@annevk annevk mentioned this issue Jul 15, 2015
Closed
@foolip
Copy link
Member

foolip commented Nov 23, 2017

Currently, HTML hooks up dialog to the inert concept directly in https://html.spec.whatwg.org/multipage/interaction.html#blocked-by-a-modal-dialog, and not via top layer.

I think the proper fix here will be to move the language about inertness into the fullscreen standard, so that when something is at the top of the top layer, everything else is inert.

scheib pushed a commit to scheib/chromium that referenced this issue Dec 1, 2017
@foolip
Make elements outside of the fullscreen element inert
f3535b8 
There is no spec for this, but an old open spec issue:
whatwg/fullscreen#15

Bug: 787867
Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a
Reviewed-on: https://chromium-review.googlesource.com/788052
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520620}
scheib pushed a commit to scheib/chromium that referenced this issue Dec 1, 2017
@foolip
Revert "Make elements outside of the fullscreen element inert"
36ed6cc 
This reverts commit f3535b8.

Reason for revert: AccessibilityFullscreenBrowserTest.IgnoreElementsOutsideFullscreenElement is flaky on linux-chromeos-rel

Original change's description:
> Make elements outside of the fullscreen element inert
> 
> There is no spec for this, but an old open spec issue:
> whatwg/fullscreen#15
> 
> Bug: 787867
> Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a
> Reviewed-on: https://chromium-review.googlesource.com/788052
> Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520620}

TBR=dmazzoni@chromium.org,mlamouri@chromium.org,foolip@chromium.org

Change-Id: I5e042244565404b7735f4e5fecc4d1194ed2a402
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787867
Reviewed-on: https://chromium-review.googlesource.com/801517
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520661}
GnorTech pushed a commit to nwjs/chromium.src that referenced this issue Dec 16, 2017
@foolip
Reland "Make elements outside of the fullscreen element inert"
b078ac3 
This is a reland of f3535b8

The IgnoreElementsOutsideFullscreenElement test was originally flaky,
due to changing textContent not reliably causing the accessibility tree
to be updated. See https://crbug.com/793078.

Original change's description:
> Make elements outside of the fullscreen element inert
>
> There is no spec for this, but an old open spec issue:
> whatwg/fullscreen#15
>
> Bug: 787867
> Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a
> Reviewed-on: https://chromium-review.googlesource.com/788052
> Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520620}

Bug: 736832, 787867, 793078
Change-Id: I5ddc56a8783dce77acf02728afc9ed621145e222
Reviewed-on: https://chromium-review.googlesource.com/810584
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522771}(cherry picked from commit 17dd72f)
Reviewed-on: https://chromium-review.googlesource.com/826943
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#223}
Cr-Branched-From: 5fdc0fa-refs/heads/master@{#520840}
@foolip foolip added the clarification Standard could be clearer label Dec 6, 2018
@zcorpan
Copy link
Member

zcorpan commented Feb 23, 2023

CSS WG discussed how fullscreen affects :modal in w3c/csswg-drafts#7311 (comment)

RESOLVED: Fullscreen elements should inert the stuff behind them, and match :modal

@zcorpan zcorpan mentioned this issue Feb 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcorpan @foolip @annevk