From 5da5838efb5896fed737a1d5f27a6e9e5b762b4c Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Tue, 21 Jul 2020 17:45:24 -0400 Subject: [PATCH] Expand JS error serialization * Generalize the framework to work on any NativeError types introduced by the JS spec, instead of listing them explicitly in a way that could require future updates. * Also include WebAssembly Error classes. * Switch semantics for serializing/deserializing "message". Previously, we would check for the presence of the property, and if it was a data property, get its value, and then ToString() it. Now, we just Get() it and then structured-serialize the result. We also unconditionally install it on the other side, regardless of whether it was present on the original. This new property-cloning procedure is more general. * Use these new more general property cloning procedure on "cause" (for all errors) and "errors" (for objects that present as "AggregateError" objects). Closes #5716. --- source | 110 ++++++++++++++++++++++++++++++++++----------------------- 1 file changed, 65 insertions(+), 45 deletions(-) diff --git a/source b/source index cf487e9120d..b13c0964e93 100644 --- a/source +++ b/source @@ -2764,19 +2764,15 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute @@isConcatSpreadable, @@toPrimitive, and @@toStringTag +
  • NativeError
  • Well-Known Intrinsic Objects, including %Array.prototype%, %Error.prototype%, - %EvalError.prototype%, + %AggregateError.prototype%, %Function.prototype%, %JSON.parse%, %Object.prototype%, - %Object.prototype.valueOf%, - %RangeError.prototype%, - %ReferenceError.prototype%, - %SyntaxError.prototype%, - %TypeError.prototype%, and - %URIError.prototype%
    • + %Object.prototype.valueOf%.
  • The FunctionBody production
  • The Module production
    • @@ -2890,6 +2886,14 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
  • The HostGetSupportedImportAssertions abstract operation
    • +

    User agents that support JavaScript must also implement the Error Cause + proposal. The following terms are defined there, and used in this specification:

    + + +

    The following terms are defined in the JSON modules proposal and used in this specification:

    @@ -2908,6 +2912,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute @@ -8325,26 +8330,35 @@ interface DOMStringList {

  • Let name be ? Get(value, "name").

    • -

  • If name is not one of "Error", "EvalError", "RangeError", "ReferenceError", - "SyntaxError", "TypeError", or "URIError", then set name to "Error".

    • +

  • If name is neither "AggregateError", nor one of the + NativeError names, nor one of the WebAssembly Error class + names, then set name to "Error".

    • + +

  • Let message be ? StructuredSerializeInternal(? Get(value, "message"), forStorage, + memory).

    • + +

  • Let cause be ? StructuredSerializeInternal(? Get(value, "cause"), forStorage, + memory).

    • -

  • Let valueMessageDesc be ? value.[[GetOwnProperty]]("message").

    • +

  • Let errors be undefined.

    • -

  • Let message be undefined if - IsDataDescriptor(valueMessageDesc) is false, and - ? ToString(valueMessageDesc.[[Value]]) otherwise.

    • +

  • If name is "AggregateError", then set errors to ? + StructuredSerializeInternal(? Get(value, + "errors"), forStorage, memory).

  • Set serialized to { [[Type]]: "Error", [[Name]]: name, - [[Message]]: message }.

    • + [[Message]]: message, [[Cause]]: cause, [[Errors]]: errors + }.

  • -

    User agents should attach a serialized representation of any interesting accompanying - data which are not yet specified, notably the stack property, to +

    User agents should attach a serialized representation of any interesting accompanying data + which are not yet specified, notably the stack property, to serialized.

    -

    See the Error Stacks proposal for in-progress work on - specifying this data.

    +

    See the Error Stacks proposal for in-progress work on specifying + this data.

    • @@ -8520,8 +8534,8 @@ interface DOMStringList {

    If ! HasOwnProperty(value, key) is true, then:

      -

    1. Let inputValue be ? value.[[Get]](key, - value).

      2. +

    2. Let inputValue be ? Get(value, + key).

    3. Let outputValue be ? StructuredSerializeInternal(inputValue, forStorage, @@ -8737,38 +8751,41 @@ o.myself = o;

      Otherwise, if serialized.[[Type]] is "Error", then:

        -

      1. Let prototype be %Error.prototype%.

        2. - -

      2. If serialized.[[Name]] is "EvalError", then set prototype to - %EvalError.prototype%.

        3. +

      3. Let name be serialized.[[Name]].

        4. -

      4. If serialized.[[Name]] is "RangeError", then set prototype - to %RangeError.prototype%.

        5. +

      5. Let prototype be + targetRealm.[[Intrinsics]].[[%name%.prototype]], or the equivalent if + name is a WebAssembly Error class name.

        6. -

      6. If serialized.[[Name]] is "ReferenceError", then set - prototype to %ReferenceError.prototype%.

        7. +

      7. Set value to ! ObjectCreate(prototype, « + [[ErrorData]] »).

        8. -

      8. If serialized.[[Name]] is "SyntaxError", then set prototype - to %SyntaxError.prototype%.

        9. +

      9. Let message be ? + StructuredDeserialize(serialized.[[Message]], targetRealm, + memory).

        10. -

      10. If serialized.[[Name]] is "TypeError", then set prototype to - %TypeError.prototype%.

        11. +

      11. Perform ! CreateNonEnumerableDataPropertyOrThrow(value, + "message", message).

        12. -

      12. If serialized.[[Name]] is "URIError", then set prototype to - %URIError.prototype%.

        13. +

      13. Let cause be ? + StructuredDeserialize(serialized.[[Cause]], targetRealm, + memory).

        14. -

      14. Let message be serialized.[[Message]].

        15. +

      15. Perform ! CreateNonEnumerableDataPropertyOrThrow(value, "cause", + cause).

        16. -

      16. Set value to ! ObjectCreate(prototype, « - [[ErrorData]] »).

        17. +
      17. +

        If name is "AggregateError", then:

        -

      18. Let messageDesc be PropertyDescriptor{ [[Value]]: - message, [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true - }.

        19. +
          +

        1. Let errors be ? + StructuredDeserialize(serialized.[[Errors]], targetRealm, + memory).

          2. -

        2. If message is not undefined, then perform ! - OrdinaryDefineOwnProperty(value, "message", - messageDesc).

          3. +

        3. Perform ! CreateNonEnumerableDataPropertyOrThrow(value, + "errors", errors).

          4. +
        +

      19. Any interesting accompanying data attached to serialized should be deserialized and attached to value.

        20. @@ -125405,6 +125422,9 @@ INSERT INTERFACES HERE
        [JPEG]
        JPEG File Interchange Format, E. Hamilton.
        +
        [JSERRORCAUSE]
        +
        Error Cause. Ecma International.
        +
        [JSERRORSTACKS]
        (Non-normative) Error Stacks. Ecma International.
        @@ -125671,7 +125691,7 @@ INSERT INTERFACES HERE
        uuid, B. Coe, R. Kieffer, C. Tavan. WICG.
        [WASMJS]
        -
        (Non-normative) WebAssembly JavaScript Interface, D. Ehrenberg. W3C.
        +
        WebAssembly JavaScript Interface, D. Ehrenberg. W3C.
        [WCAG]
        (Non-normative) Web Content Accessibility Guidelines (WCAG), A. Kirkpatrick, J. O Connor, A. Campbell, M. Cooper. W3C.