Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should dialog removal steps unset is modal flag? #10452

Closed
lukewarlow opened this issue Jul 1, 2024 · 3 comments · Fixed by #10459
Closed

Should dialog removal steps unset is modal flag? #10452

lukewarlow opened this issue Jul 1, 2024 · 3 comments · Fixed by #10459
Labels
topic: dialog The <dialog> element.

Comments

@lukewarlow
Copy link
Member

What is the issue with the HTML Standard?

The dialog element's removal steps don't set is modal flag to false. See https://html.spec.whatwg.org/#pseudo-classes:is-modal:~:text=dialog%20HTML%20element%20removing%20steps

I would expect this to happen based on the first sub-test's final assertion inside of https://wpt.live/css/selectors/modal-pseudo-class.html
@lukewarlow lukewarlow added the topic: dialog The <dialog> element. label Jul 1, 2024
@lukewarlow
Copy link
Member Author

It's sort of odd that removing a dialog doesn't close it, this is what popover does?

It's particularly strange that if you remove a modal dialog and re-add it it's still open but now it's not modal (or in the top layer)?

@lukewarlow lukewarlow mentioned this issue Jul 1, 2024
Merged
@domenic
Copy link
Member

domenic commented Jul 2, 2024

I think #5802 is pretty related.

@lukewarlow lukewarlow mentioned this issue Jul 3, 2024
Merged
5 tasks
@lukewarlow
Copy link
Member Author

Turns out this was already raised here #6216 and fixed here 9fcb6c3 so it seems to have regressed somehow?

domenic pushed a commit that referenced this issue Jul 8, 2024
@lukewarlow
Set dialog is modal to false when removed from the document
baeea82 
Fixes #10452.

This accidentally regressed in 8430871.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: dialog The <dialog> element.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set dialog is modal to false when removed from the document. lukewarlow/html
2 participants
@domenic @lukewarlow