Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"traverse the history by a delta" is unclear #1523

Closed
annevk opened this issue Jul 8, 2016 · 2 comments
Closed

"traverse the history by a delta" is unclear #1523

annevk opened this issue Jul 8, 2016 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Jul 8, 2016

In step 3 of https://html.spec.whatwg.org/multipage/browsers.html#traverse-the-history-by-a-delta we grab a session history entry's browsing context. Except it stores no such thing. Should it grab that from the session history entry's Document object instead? What if that's not there?

Or maybe it should store a reference to the browsing context?

This might relate to #1454, which is a little more ambitious and should probably also be done, but maybe we can get there in smaller steps.

@smaug---- @majido

@smaug----
Copy link

Doesn't the step 3 mean that we use the browsing context with which the entry is associated with? In the spec every entry after all belongs to session history of some browsing context, right?
(and that is a part not compatible with implementations, and that is what #1454 is about.)

@annevk
Copy link
Member Author

annevk commented Jul 8, 2016

In the spec every entry after all belongs to session history of some browsing context, right?

In the standard, a session history entry belongs to a session history which belongs to a browsing context. I guess that's the link I was missing. The specification doesn't explicitly state that a session history entry holds a pointer to a browsing context.

Anyway, I'll close this in favor of your larger issue since it seems they cannot really be decoupled.

@annevk annevk closed this as completed Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants