Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with DOM DocumentFragment adoption changes #5413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

annevk
Copy link
Member

@annevk annevk commented Mar 28, 2020

Complements whatwg/dom#819.

Thoughts on how to pass boolean variables? I wish we had a better pattern for them.

(See WHATWG Working Mode: Changes for more details.)


/scripting.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on how to pass boolean variables? I wish we had a better pattern for them.

I don't like using <var> for something that is never "let" or "set". Any of the following would be reasonable to me:

  • "into doc, with true" (or "passing true")
  • "into doc, with [force document fragment adoption] set to true", where that's a link to a <dfn>
  • "into doc, with true for the the force document fragment adoption parameter" (no link)

@annevk annevk requested a review from domenic March 31, 2020 07:01
@annevk
Copy link
Member Author

annevk commented Mar 31, 2020

Addressed feedback, but whatwg/html-build#218 is happening now.

Base automatically changed from master to main January 15, 2021 07:57
source Outdated Show resolved Hide resolved
annevk added a commit to whatwg/dom that referenced this pull request Oct 18, 2022
@annevk annevk added the agenda+ To be discussed at a triage meeting label Oct 20, 2022
<li><p><span data-x="concept-node-adopt">Adopt</span> <var>node</var>'s
<span>template contents</span> (a <code>DocumentFragment</code> object) into <var>doc</var>.</p></li>
<li><p><span data-x="concept-node-adopt">Adopt</span> <var>node</var>'s <span>template
contents</span> into <var>doc</var>, with true.</p></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (adding , with true) is ok by me. But there seems to be a compat issue with the more general change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants