Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make togglePopover throw more exceptions #9451

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Make togglePopover throw more exceptions #9451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
032125c
Make togglePopover throw more exceptions
josepharhar Jun 21, 2023
cf83091
replace comma with semicolon
josepharhar Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82726,6 +82726,19 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
<li><p>Otherwise, if <var>force</var> is not present or true, then run <span>show popover</span>
given <span>this</span> true, and null.</p></li>

<li>
<p>Otherwise:</p>

<ol>
<li><p>Let <var>expectedToBeShowing</var> be true if <span>this</span>'s <span>popover
visibility state</span> is <span data-x="popover-showing-state">showing</span>; otherwise
josepharhar marked this conversation as resolved.
Show resolved Hide resolved
false.</p></li>

<li><p>Run <span>check popover validity</span> given <var>expectedToBeShowing</var>, true, and
null.</p></li>
</ol>
</li>

<li><p>Return true if <span>this</span>'s <span>popover visibility state</span> is <span
data-x="popover-showing-state">showing</span>; otherwise false.</p></li>
</ol>
Expand Down