-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of "entry settings object" #86
Comments
Indeed, that particular usage will require tests for the |
@domenic I know you wrote tests for this for other APIs, do you have a pointer perhaps? Would be nice to get this resolved. |
The HTML issue doesn't have any links, which I guess means we don't have any for the changes to |
If you follow the links from the HTML issue you can end up at e.g. web-platform-tests/wpt#3449 |
@annevk any interest in helping with tests for this? It looks pretty difficult as you need to set up origins where only one of them is granted permission, I guess. I can also tell you from code inspection that Chrome does the relevant settings object (or current for statics) so maybe we should just change this without tests? |
Yeah, I think that would be okay. |
Use the relevant settings object instead. Fixes #86.
Use the relevant settings object instead. Fixes #86.
Use the relevant global/settings object where possible. Use the current global/settings object in statics. Fixes #86.
It seems most can be replaced with "relevant settings object" easily, but not entirely sure about usage in https://notifications.spec.whatwg.org/#create-a-notification.
The text was updated successfully, but these errors were encountered: