Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of "entry settings object" #86

Closed
annevk opened this issue Nov 21, 2016 · 6 comments · Fixed by #168
Closed

Remove usage of "entry settings object" #86

annevk opened this issue Nov 21, 2016 · 6 comments · Fixed by #168

Comments

@annevk
Copy link
Member

annevk commented Nov 21, 2016

It seems most can be replaced with "relevant settings object" easily, but not entirely sure about usage in https://notifications.spec.whatwg.org/#create-a-notification.

@domenic
Copy link
Member

domenic commented Nov 22, 2016

Indeed, that particular usage will require tests for the new Notification() case. I am pretty sure Chrome and Firefox at least do not use entry based on code inspection/conversations with Boris, so we'll probably get lucky there.

@annevk
Copy link
Member Author

annevk commented Apr 24, 2017

@domenic I know you wrote tests for this for other APIs, do you have a pointer perhaps? Would be nice to get this resolved.

@annevk
Copy link
Member Author

annevk commented Apr 24, 2017

The HTML issue doesn't have any links, which I guess means we don't have any for the changes to fetch() and XMLHttpRequest either.

@domenic
Copy link
Member

domenic commented Apr 24, 2017

If you follow the links from the HTML issue you can end up at e.g. web-platform-tests/wpt#3449

@domenic
Copy link
Member

domenic commented Apr 14, 2021

@annevk any interest in helping with tests for this? It looks pretty difficult as you need to set up origins where only one of them is granted permission, I guess.

I can also tell you from code inspection that Chrome does the relevant settings object (or current for statics) so maybe we should just change this without tests?

@annevk
Copy link
Member Author

annevk commented Apr 15, 2021

Yeah, I think that would be okay.

annevk added a commit that referenced this issue Apr 22, 2021
Use the relevant settings object instead.

Fixes #86.
annevk added a commit that referenced this issue Apr 26, 2021
Use the relevant settings object instead.

Fixes #86.
annevk added a commit that referenced this issue Apr 27, 2021
Use the relevant global/settings object where possible. Use the current global/settings object in statics.

Fixes #86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants