-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakage #1
Comments
We could rename it. If we do it in a single commit history will still be there in Git, although it looks like the GitHub UI does not follow renames :(. So, maybe not worth it... I guess we could hard-code an exception into the tool, if we anticipate this being a long-term issue.
We should fix the editorconfig and the spec to align.
This seems to be due to the The other divergences can be removed.
We should fix
We should align it. Although, we could copy some of its additions, which are reasonable practice:
(See here for the
Oh wow, that's why my editor keeps resetting to indent_size 2!
I would like to remove Node from the build process at some point, and align on indent/line length. |
It now works for everything except HTML and Streams. I'll still PR Streams with some local tweaks as overall it's an improvement there too. |
a10cf79 excludes HTML/Streams. I suspect Streams can soon be enabled again and for HTML we probably want to to update a subset of files only. |
Streams was fixed in #15. |
Currently there are the following issues. Since we don't run this often it's unclear whether they need to be resolved.
compatibility.bs
while its shortname iscompat
./UnicodeData.txt
in.gitignore
..gitignore
. Probably because building is done elsewhere..pr-preview.json
, but also seems to have some errors there (e.g., does not overwrite h1).Overall it works pretty well though (for 10 out of 15, and for the remaining 5 it still helps identifying issues) and ends up adding PULL_REQUEST_TEMPLATE.md to a bunch of places as well as making minor ordering changes to
.gitignore
.The text was updated successfully, but these errors were encountered: