Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing test coverage for destructuring arguments and GetV. #962

Closed
ricea opened this issue Nov 7, 2018 · 2 comments
Closed

Missing test coverage for destructuring arguments and GetV. #962

ricea opened this issue Nov 7, 2018 · 2 comments
Labels
tests

Comments

@ricea
Copy link
Collaborator

ricea commented Nov 7, 2018

For example getReader(null) should throw. getReader(7) should work. getReader('hi') should work, unless you set String.prototype.mode = 'not byob' first.

Similar concerns apply where the standard uses GetV.
@ricea ricea added the tests label Nov 7, 2018
@domenic domenic mentioned this issue Nov 7, 2018
Closed
@ricea
Copy link
Collaborator Author

ricea commented Nov 22, 2018

If we switch to Web IDL getReader(7) will no longer work, so maybe we should hold off adding tests for it.

@domenic
Copy link
Member

domenic commented Jun 26, 2020

This is no longer supported after #1035, and idlharness tests it.

@domenic domenic closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @ricea