Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 parser and the empty string as input #96

Closed
triple-underscore opened this issue Feb 27, 2016 · 2 comments
Closed

IPv4 parser and the empty string as input #96

triple-underscore opened this issue Feb 27, 2016 · 2 comments

Comments

@triple-underscore
Copy link

https://url.spec.whatwg.org/#concept-ipv4-parser

It is unclear what happen if the empty string is passed to the IPv4 parser as input.
The step 3 makes the "parts" list empty, and the algorithm gets stuck at the step 11.
(Probably, the algorithm should return the same input. )

@annevk
Copy link
Member

annevk commented Feb 27, 2016

This is a duplicate of #79 in a way, but I'll leave it open for now.

There's one question here as I see it:

  1. Should other standards be able to directly invoke the IPv4 parser? (Inclined to say no.)

If they cannot, then it's simply a matter of making sure that either IPv4 handles it or the host parser never invokes it with the empty string.

@annevk
Copy link
Member

annevk commented Dec 29, 2016

I have a fix for #79 in #189. Marking this as a duplicate since it appears to be a concrete one after all.

@annevk annevk closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants