Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect renormalisation of atom numbers in spinor cases #22

Closed
wheelerMT opened this issue Nov 8, 2024 · 0 comments · Fixed by #23
Closed

Incorrect renormalisation of atom numbers in spinor cases #22

wheelerMT opened this issue Nov 8, 2024 · 0 comments · Fixed by #23
Labels
bug Something isn't working

Comments

@wheelerMT
Copy link
Owner

wheelerMT commented Nov 8, 2024

Bug Report

Current Behavior
When using complex or purely imaginary time, the wavefunction is automatically renormalised by PyGPE. However, in spinor condensates this renormalisation is not implemented correctly.

Currently, each component is renormalised using the atom number of that component, rather than the total atom number of the system. This means that the atom numbers of the individual components always remains constant, and hence certain dynamics cannot occur, e.g., phase transitions,

Expected behavior/code
Correct normalisation of condensate components in spinor cases should occur.

Environment

  • Python version(s): 3.12
  • OS: MacOS Sequoia 15.1

Possible Solution
Apply the renormalisation using the overall atom number of the condensate.

@wheelerMT wheelerMT added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant