Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whipper not finding the drive (whipper docker install) #499

Closed
dabac76 opened this issue Jul 19, 2020 · 4 comments
Closed

whipper not finding the drive (whipper docker install) #499

dabac76 opened this issue Jul 19, 2020 · 4 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Milestone

Comments

@dabac76
Copy link

dabac76 commented Jul 19, 2020

My system (Manjaro 20, 64bit) :

sudo lshw -C disk
*-cdrom
description: DVD-RAM writer
product: CDDVDW SH-224BB
vendor: TSSTcorp
physical id: 0
bus info: scsi@2:0.0.0
logical name: /dev/cdrom
logical name: /dev/sr0
version: SB00
capabilities: removable audio cd-r cd-rw dvd dvd-r dvd-ram
configuration: ansiversion=5 status=ready
*-medium
physical id: 0
logical name: /dev/cdrom

I have installed whipper with : docker pull whipperteam/whipper and I am using the recommended alias with --device /dev/cdrom

whipper drive list

CRITICAL:whipper.command.drive:no drives found. Create /dev/cdrom if you have a CD drive, or install pycdio for better detection

@dabac76 dabac76 changed the title whipper drive list not finding the driver (whipper docker install) whipper not finding the drive (whipper docker install) Jul 19, 2020
@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@ghost
Copy link

ghost commented Jul 25, 2020

Could it be a group issue?

@dabac76
Copy link
Author

dabac76 commented Jul 28, 2020

cdrom group inside the container has GID=24. Manjaro defines group named optical with access rights to /dev/sr0 and /dev/sg0 with GID=990. Since these don't match, container is not able to use the optical device.

Quick and unsafe workaround would be the following change to docker run :
docker run -ti --rm --privileged -v /dev/cdrom:/dev/cdrom ... (where on host side /dev/cdrom is a symlink owned by root to /dev/sr0)

More subtle solution that avoids the --privileged flag would be to change the Dockerfile so that it picks the right GID for optical device on the host side and adds worker to this group. For example, a quick hard-coded change in my case was:

# add user
RUN groupadd -f -g 990 optical \
    && useradd -m -u 1000 worker -G optical,cdrom \
    ...

And then run container with:

docker run -ti --device /dev/sr0 ...

@JoeLametta
Copy link
Collaborator

@dabac76 Hopefully this issue should now be solved with commit 8676e25 (untested).

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels labels Aug 10, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Projects
None yet
Development

No branches or pull requests

2 participants