Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

got exception IndexError('list index out of range') #512

Closed
bydioeds opened this issue Oct 4, 2020 · 4 comments
Closed

got exception IndexError('list index out of range') #512

bydioeds opened this issue Oct 4, 2020 · 4 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels

Comments

@bydioeds
Copy link

bydioeds commented Oct 4, 2020

When trying to rip i get this error at the last track

DEBUG:whipper.extern.task.task:notifying progress: 0.9937835144497699 on 'Verifying track 11 of 12 (3 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.9937835144497699 on 'Verifying track 11 of 12'
DEBUG:whipper.extern.task.task:notifying progress: 1.0 on 'Verifying track 11 of 12 (3 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 1.0 on 'Verifying track 11 of 12'
DEBUG:whipper.program.cdparanoia:getTrackQuality: frames 21073, reads 41456
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.program.cdparanoia.ReadTrackTask object at 0xb5baf6d0> (3 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: pick next task
DEBUG:whipper.extern.task.task:MultiSeparateTask.next()
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): starting task 4 of 9: <whipper.common.checksum.CRC32Task object at 0xb5baf370>
DEBUG:whipper.extern.task.task:Adding listener <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'I am doing something. (4 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'I am doing something.'
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): started task 4 of 9: <whipper.common.checksum.CRC32Task object at 0xb5baf370>
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.common.checksum.CRC32Task object at 0xb5baf370> (4 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: pick next task
DEBUG:whipper.extern.task.task:MultiSeparateTask.next()
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): starting task 5 of 9: <whipper.common.encode.FlacEncodeTask object at 0xb5bafad8>
DEBUG:whipper.extern.task.task:Adding listener <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Encoding track to FLAC (5 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Encoding track to FLAC'
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): started task 5 of 9: <whipper.common.encode.FlacEncodeTask object at 0xb5bafad8>
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.common.encode.FlacEncodeTask object at 0xb5bafad8> (5 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: pick next task
DEBUG:whipper.extern.task.task:MultiSeparateTask.next()
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): starting task 6 of 9: <whipper.common.checksum.CRC32Task object at 0xb5baf940>
DEBUG:whipper.extern.task.task:Adding listener <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'I am doing something. (6 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'I am doing something.'
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): started task 6 of 9: <whipper.common.checksum.CRC32Task object at 0xb5baf940>
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.common.checksum.CRC32Task object at 0xb5baf940> (6 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: pick next task
DEBUG:whipper.extern.task.task:MultiSeparateTask.next()
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): starting task 7 of 9: <whipper.common.encode.SoxPeakTask object at 0xb5baf310>
DEBUG:whipper.extern.task.task:Adding listener <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Calculating peak level (7 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Calculating peak level'
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): started task 7 of 9: <whipper.common.encode.SoxPeakTask object at 0xb5baf310>
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.common.encode.SoxPeakTask object at 0xb5baf310> (7 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: pick next task
DEBUG:whipper.extern.task.task:MultiSeparateTask.next()
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): starting task 8 of 9: <whipper.common.encode.TaggingTask object at 0xb5baf088>
DEBUG:whipper.extern.task.task:Adding listener <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Writing tags to FLAC (8 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Writing tags to FLAC'
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): started task 8 of 9: <whipper.common.encode.TaggingTask object at 0xb5baf088>
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.common.encode.TaggingTask object at 0xb5baf088> (8 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: pick next task
DEBUG:whipper.extern.task.task:MultiSeparateTask.next()
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): starting task 9 of 9: <whipper.common.encode.EmbedPictureTask object at 0xb5bafb20>
DEBUG:whipper.extern.task.task:Adding listener <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:starting
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Embed picture to FLAC (9 of 9) ...'
DEBUG:whipper.extern.task.task:notifying progress: 0.0 on 'Embed picture to FLAC'
DEBUG:whipper.extern.task.task:BaseMultiTask.next(): started task 9 of 9: <whipper.common.encode.EmbedPictureTask object at 0xb5bafb20>
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: task <whipper.common.encode.EmbedPictureTask object at 0xb5bafb20> (9 of 9)
DEBUG:whipper.extern.task.task:BaseMultiTask.stopped: all tasks done
DEBUG:whipper.program.cdparanoia:peak: 32767
INFO:whipper.program.cdparanoia:checksums match, e06b3890
DEBUG:whipper.program.cdparanoia:moving to final path './album/Miguel Bosé - Los chicos no lloran/11. Miguel Bosé - Josephine.flac'
DEBUG:whipper.extern.task.task:stopping
DEBUG:whipper.extern.task.task:reset runner to None
DEBUG:whipper.extern.task.task:stopped task <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.extern.task.task:done running task <whipper.program.cdparanoia.ReadVerifyTrackTask object at 0xb5bafbe0>
DEBUG:whipper.common.program:ripped track
DEBUG:whipper.common.program:test speed 8.176/34.364 seconds
DEBUG:whipper.common.program:copy speed 8.143/34.507 seconds
INFO:whipper.command.cd:CRCs match for track 11
DEBUG:whipper.image.table:setFile: track 11, index 1, path './album/Miguel Bosé - Los chicos no lloran/11. Miguel Bosé - Josephine.flac', length 21073, counter 11
DEBUG:whipper.image.table:setting path './album/Miguel Bosé - Los chicos no lloran/11. Miguel Bosé - Josephine.flac', relative 0 on track 11, index 1, counter 11
DEBUG:whipper.image.table:setting path './album/Miguel Bosé - Los chicos no lloran/11. Miguel Bosé - Josephine.flac', relative 21035 on track 12, index 0, counter 11
DEBUG:whipper.command.cd:ripIfNotRipped for track 12
DEBUG:whipper.command.cd:ripIfNotRipped: path './album/Miguel Bosé - Los chicos no lloran/12. Miguel Bosé - Mix otoño.flac'
DEBUG:whipper.command.cd:path './album/Miguel Bosé - Los chicos no lloran/12. Miguel Bosé - Mix otoño.flac' does not exist, ripping...
INFO:whipper.command.cd:ripping track 12 of 12: 12. Miguel Bosé - Mix otoño.flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 12, try 1
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 1
INFO:whipper.command.cd:ripping track 12 of 12 (try 2): 12. Miguel Bosé - Mix otoño.flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 12, try 2
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 2
INFO:whipper.command.cd:ripping track 12 of 12 (try 3): 12. Miguel Bosé - Mix otoño.flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 12, try 3
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 3
INFO:whipper.command.cd:ripping track 12 of 12 (try 4): 12. Miguel Bosé - Mix otoño.flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 12, try 4
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 4
INFO:whipper.command.cd:ripping track 12 of 12 (try 5): 12. Miguel Bosé - Mix otoño.flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 12, try 5
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 5
CRITICAL:whipper.command.cd:giving up on track 12 after 5 times
@b-buyman
Copy link

b-buyman commented Nov 17, 2020 •
edited
Loading

I can confirm this bug for version 0.9.1.dev100+g04ff005. Tested with multiple CDs and drives. 0.9.0 works fine on the same system.

DEBUG:whipper.image.table:setFile: track 13, index 1, path './compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/13. Parov Stelar feat. Lilja Bloom - Shine.flac', length 16324, counter 13
DEBUG:whipper.image.table:setting path './compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/13. Parov Stelar feat. Lilja Bloom - Shine.flac', relative 0 on track 13, index 1, counter 13
DEBUG:whipper.command.cd:ripIfNotRipped for track 14
DEBUG:whipper.command.cd:ripIfNotRipped: path "./compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/14. Parov Stelar - Jimmy's Gang (radio edit).flac"
DEBUG:whipper.command.cd:path "./compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/14. Parov Stelar - Jimmy's Gang (radio edit).flac" does not exist, ripping...
INFO:whipper.command.cd:ripping track 14 of 14: 14. Parov Stelar - Jimmy's Gang (radio edit).flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 1
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 1
INFO:whipper.command.cd:ripping track 14 of 14 (try 2): 14. Parov Stelar - Jimmy's Gang (radio edit).flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 2
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 2
INFO:whipper.command.cd:ripping track 14 of 14 (try 3): 14. Parov Stelar - Jimmy's Gang (radio edit).flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 3
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 3
INFO:whipper.command.cd:ripping track 14 of 14 (try 4): 14. Parov Stelar - Jimmy's Gang (radio edit).flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 4
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 4
INFO:whipper.command.cd:ripping track 14 of 14 (try 5): 14. Parov Stelar - Jimmy's Gang (radio edit).flac
DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 5
DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 5
CRITICAL:whipper.command.cd:giving up on track 14 after 5 times

I can run mor tests / provide more information if needed.

Edit: Sorry, fixed the code formatting.

@bydioeds
Copy link
Author

I can confirm this bug for version 0.9.1.dev100+g04ff005. Tested with multiple CDs and drives. 0.9.0 works fine on the same system.

DEBUG:whipper.image.table:setFile: track 13, index 1, path './compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/13. Parov Stelar feat. Lilja Bloom - Shine.flac', length 16324, counter 13 DEBUG:whipper.image.table:setting path './compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/13. Parov Stelar feat. Lilja Bloom - Shine.flac', relative 0 on track 13, index 1, counter 13 DEBUG:whipper.command.cd:ripIfNotRipped for track 14 DEBUG:whipper.command.cd:ripIfNotRipped: path "./compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/14. Parov Stelar - Jimmy's Gang (radio edit).flac" DEBUG:whipper.command.cd:path "./compilation/Parov Stelar - The Art of Sampling (Disc 1 of 2)/14. Parov Stelar - Jimmy's Gang (radio edit).flac" does not exist, ripping... INFO:whipper.command.cd:ripping track 14 of 14: 14. Parov Stelar - Jimmy's Gang (radio edit).flac DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 1 DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 1 INFO:whipper.command.cd:ripping track 14 of 14 (try 2): 14. Parov Stelar - Jimmy's Gang (radio edit).flac DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 2 DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 2 INFO:whipper.command.cd:ripping track 14 of 14 (try 3): 14. Parov Stelar - Jimmy's Gang (radio edit).flac DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 3 DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 3 INFO:whipper.command.cd:ripping track 14 of 14 (try 4): 14. Parov Stelar - Jimmy's Gang (radio edit).flac DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 4 DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 4 INFO:whipper.command.cd:ripping track 14 of 14 (try 5): 14. Parov Stelar - Jimmy's Gang (radio edit).flac DEBUG:whipper.command.cd:ripIfNotRipped: track 14, try 5 DEBUG:whipper.command.cd:got exception IndexError('list index out of range') on try 5 CRITICAL:whipper.command.cd:giving up on track 14 after 5 times

I can run mor tests / provide more information if needed.

this worked for me you can just change these lines

whipper/whipper/command/cd.py

Lines 454 to 455 in 04ff005

if self.itable.tracks[number].isrc is not None:
tag_list['ISRC'] = self.itable.tracks[number].isrc

to this, hope this works for you

 if self.itable.tracks[number-1].isrc is not None: 
     tag_list['ISRC'] = self.itable.tracks[number-1].isrc

@MerlijnWajer
Copy link
Collaborator

Have you also verified that this writes the right ISRC tags to the right tracks? It seems plausible to me, but just checking.

@MerlijnWajer
Copy link
Collaborator

Looks like this might have broken it: 3c9e75c#diff-2c8e39a955bd26e27f024b8f040d38965d7ee32947086a1ec0ee0b773ba9f34d

@MerlijnWajer MerlijnWajer mentioned this issue Nov 17, 2020
Merged
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels labels Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MerlijnWajer @bydioeds @JoeLametta @b-buyman