Accept raw string confirmation code on confirm device #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
=====================================
Coverage 4.16% 4.16%
=====================================
Files 36 36
Lines 2523 2523
=====================================
Hits 105 105
Misses 2418 2418
|
|
Cherry-picked into #238 |
rubdos
reviewed
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a panic here today, seems to have been changed recently.
Removes u32 validation, since it seems signal isn't sticking to u32 codes. Besides, it's just converting to a u32 to then converting back to a string on the url. Backwards compatible.