Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown contact handling #98

Closed
nanu-c opened this issue Jan 21, 2023 · 4 comments · Fixed by #211
Closed

Unknown contact handling #98

nanu-c opened this issue Jan 21, 2023 · 4 comments · Fixed by #211
Milestone

Comments

@nanu-c
Copy link
Contributor

nanu-c commented Jan 21, 2023

If i receive a message from an unknown contact it should create a new contact and fetch the profile for the username.

@Schmiddiii
Copy link
Contributor

Maybe I misunderstand contacts and profiles, but what I think is that contacts are "known numbers" that may optionally be assigned a name in Signal, and profiles are what a person advertises itself to be. So in my opinion, contact names should not be assigned the profile names, instead the application should first query the contact name, and if that does not exist, fetch the profile and show that as a fallback.

@nanu-c
Copy link
Contributor Author

nanu-c commented Feb 2, 2023

Actually in Signal-Android every person, also all the persons in all groups are transformed to a contact in the contact list. The "name" of the person/chat will be the username until i define another name in the contact.

presage currently only fetches the contacts on registering from the "main" signal registration. When a "new" person sends me a message the contact isn't created and if it's created, the message doesn't contain a username. So for creating a new contact the profile has to be fetched.

@Schmiddiii
Copy link
Contributor

I did not think so, but if that is how Signal-Android does it, presage can also do it like that. What made me a bit sceptical was if Signal-Android auto-sets the contact name, why do some contacts of a contact sync not contain the profile name, but instead None. But as mentioned, if that is how it is done in Signal Android, I am fine with doing it like you suggested.

@nanu-c
Copy link
Contributor Author

nanu-c commented Feb 2, 2023

Some time ago they changed the registration process, that it's not possible anymore to set no username. I think the Nones are historical relicts.

@gferon gferon added this to the 0.5.2 milestone Apr 21, 2023
@gferon gferon modified the milestones: 0.5.3, 0.6.0 Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants