Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Syft+ version to v0.1.1 #119

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Fix Syft+ version to v0.1.1 #119

merged 1 commit into from
Aug 14, 2021

Conversation

marcofavorito
Copy link
Member

Types of changes

Fix Syft+ version to v0.1.1.

That release fixes an incompatibility between Syft+ and Lydia. Before that release, Syft+ used to transform in uppercase all the variable names parsed from the partfile. However, in case of lowercase variable names in the formula, this ended up in variables not being considered in the synthesis task, causing malfunctioning of the Lydia synthesis feature.

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marcofavorito marcofavorito mentioned this pull request Aug 14, 2021
9 tasks
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #119 (dbb8cf3) into develop (d29c4f8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #119      +/-   ##
===========================================
+ Coverage    46.79%   46.82%   +0.02%     
===========================================
  Files           77       77              
  Lines         3874     3874              
  Branches      1794     1794              
===========================================
+ Hits          1813     1814       +1     
+ Misses         848      843       -5     
- Partials      1213     1217       +4     
Flag Coverage Δ
unittests 46.82% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/src/logic/ltlf/base.cpp 14.11% <0.00%> (-0.41%) ⬇️
lib/src/logic/ldlf/base.cpp 57.00% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d29c4f8...dbb8cf3. Read the comment docs.

@marcofavorito marcofavorito merged commit bad2a7d into develop Aug 14, 2021
@marcofavorito marcofavorito deleted the fix/syft-version branch August 14, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant